Skip to content

[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov" - #160573

Closed
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:revert-159339
Closed

[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov"#160573
Kobzol wants to merge 1 commit into
rust-lang:mainfrom
Kobzol:revert-159339

Conversation

@Kobzol

@Kobzol Kobzol commented Aug 5, 2026

Copy link
Copy Markdown
Member

This reverts commit 09be986, reversing
changes made to 83c03bb.

Opening for a perf. run.

…se-injections, r=petrochenkov"

This reverts commit 09be986, reversing
changes made to 83c03bb.
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2026
@Kobzol

Kobzol commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 5, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Aug 5, 2026
[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov"
@rust-bors

rust-bors Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 8e30206 (8e30206b7ac7d2267d9de35a03ff8203b900e43f)
Base parent: 22950ab (22950ab9e29e11620a10905f027f141ea126966e)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (8e30206): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.1%] 3
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -2.4%, secondary 0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.9% [0.9%, 0.9%] 1
Improvements ✅
(primary)
-2.4% [-2.4%, -2.4%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.4% [-2.4%, -2.4%] 1

Cycles

Results (primary 2.4%, secondary -2.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
6.8% [4.9%, 8.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-7.2% [-14.4%, -2.1%] 4
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.1%] 25
Regressions ❌
(secondary)
0.0% [0.0%, 0.1%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.1%] 25

Bootstrap: 454.551s -> 457.493s (0.65%)
Artifact size: 399.93 MiB -> 399.12 MiB (-0.20%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 5, 2026
@Kobzol

Kobzol commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Hmm, no wall-time change for the 4threads benchmark. That's weird. I wonder what could have changed on the machine to suddenly make wall-time 2x slower just for the parallel benchmark.

@lqd

lqd commented Aug 5, 2026

Copy link
Copy Markdown
Member

We know now!

@Kobzol

Kobzol commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

It was rustc-perf all along. Sorry for the noise!

@Kobzol Kobzol closed this Aug 5, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants