[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov" - #160573
[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov"#160573Kobzol wants to merge 1 commit into
Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
[perf test] Revert "Rollup merge of #159339 - LorrensP-2158466:extract-use-injections, r=petrochenkov"
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (8e30206): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up. @rustbot label: -S-waiting-on-perf -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -2.4%, secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 2.4%, secondary -2.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 454.551s -> 457.493s (0.65%) |
|
Hmm, no wall-time change for the 4threads benchmark. That's weird. I wonder what could have changed on the machine to suddenly make wall-time 2x slower just for the parallel benchmark. |
|
We know now! |
|
It was rustc-perf all along. Sorry for the noise! |
This reverts commit 09be986, reversing
changes made to 83c03bb.
Opening for a perf. run.