rustc_resolve: move diagnostic attribute linting to attr parsing - #160499
Open
mejrs wants to merge 1 commit into
Open
rustc_resolve: move diagnostic attribute linting to attr parsing#160499mejrs wants to merge 1 commit into
mejrs wants to merge 1 commit into
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
JonathanBrouwer
requested changes
Aug 5, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
mejrs
force-pushed
the
move_diagnostic_attr_not_found_lint
branch
from
August 5, 2026 15:36
467a96d to
df6106e
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
It had to be in rustc_resolve because there was no general attribute parsing infra back then, but now there is, so it should be there
mejrs
force-pushed
the
move_diagnostic_attr_not_found_lint
branch
from
August 5, 2026 16:45
df6106e to
cd19505
Compare
Contributor
Author
|
I've addressed both comments as well as added a "this is an experimental diagnostic attribute" note. @rustbot ready |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was in rustc_resolve because there was no general attribute parsing infra back then, but now there is, so it should be there.
Also improves some spans.
This change also makes it so that unknown diagnostic attributes are removed, rather than stay as unparsed attributes.