Rollup of 17 pull requests by JonathanBrouwer · Pull Request #160278 · rust-lang/rust

JonathanBrouwer · 2026-07-31T11:44:34Z

Successful merges:

Add "system" option to override-allocator directive #160100 (Add "system" option to override-allocator directive)
Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
allow -Ldependency search paths for panic runtimes #160007 (allow -Ldependency search paths for panic runtimes)
rustfmt: Format cfg_select! #154202 (rustfmt: Format cfg_select!)
Move "macro only" check for #[allow_internal_unsafe/unstable] to attribute parser #160034 (Move "macro only" check for #[allow_internal_unsafe/unstable] to attribute parser)
rustc_middle: lint attribute cleanups #160066 (rustc_middle: lint attribute cleanups)
Remove various superfluous lint attributes #160085 (Remove various superfluous lint attributes)
Coalesce rustc_on_unimplemented attributes and lint malformed filters #160113 (Coalesce rustc_on_unimplemented attributes and lint malformed filters)
fix query cycle in coroutine_hidden_types for the next solver #160119 (fix query cycle in coroutine_hidden_types for the next solver)
tests: Remove -Zthreads options from tests in ui/parallel-rustc #160147 (tests: Remove -Zthreads options from tests in ui/parallel-rustc)
Remove outdated comments from va_list.rs #160157 (Remove outdated comments from va_list.rs)
More accurately check for interior mutability in invalid_reference_casting lint #160159 (More accurately check for interior mutability in invalid_reference_casting lint)
rustdoc: Fix crash when trying to list attributes on an opaque type #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
Rename splat to rustc_splat in error messages #160244 (Rename splat to rustc_splat in error messages)
dont fire unused_mut on &pin mut self #160246 (dont fire unused_mut on &pin mut self)
Configure backport nominations for rustfmt #160247 (Configure backport nominations for rustfmt)
renovate: update lock files weekly #160274 (renovate: update lock files weekly)

…ackends

`cfg_select!` parsing needs to be implemented in rustfmt right now because there's no good way to call `rustc_attr_parsing::parse_cfg_select`.

The plan is to leverage `rewrite_match_body` to help with `cfg_select!` formatting.

This allows a per-target `override-allocator` to revert to the system allocator even if there is a global rule specifying a different allocator. Remap `jemalloc = false` to `override-allocator = "system"` instead of mapping it to "override-allocator is unset"; this restores the correct precedence behaviour of this setting. This also allows `Config::override_allocator()` to always resolve the directive to a definite value, rather than needing it to be wrapped in an `Option`, which simplifies some other code. Finally, print a more specific warning when `jemalloc` is set, telling users the appropriate setting to use for `override-allocator` depending on whether `jemalloc` is set to true or false. Fixes rust-lang#160084

…bzol

JonathanBrouwer · 2026-07-31T11:44:44Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-*

rust-bors · 2026-07-31T11:44:47Z

📌 Commit 658bb19 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 17 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*

rust-log-analyzer · 2026-07-31T13:44:05Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

---- [run-make] tests\run-make\locate-panic-runtime stdout ----

error: rmake recipe failed to complete
status: exit code: 1
command: "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake.exe"
stdout: none
--- stderr -------------------------------
"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "core.rs" "-Cpanic=abort" "--sysroot" "./no_exists" "--target=i686-pc-windows-msvc"
output status: `exit code: 0`
=== STDOUT ===



=== STDERR ===



"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "panic_abort.rs" "-Cpanic=abort" "--out-dir" "panic_abort" "--sysroot" "./no_exists" "--target=i686-pc-windows-msvc"
output status: `exit code: 0`
=== STDOUT ===



=== STDERR ===



"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "std.rs" "--extern" "panic_abort=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\panic_abort\\libpanic_abort.rlib" "-Cpanic=abort" "--sysroot" "./no_exists" "--target=i686-pc-windows-msvc"
output status: `exit code: 0`
=== STDOUT ===



=== STDERR ===



"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "lib.rs" "-Cpanic=abort" "--sysroot" "./no_exists" "--target=i686-pc-windows-msvc"
output status: `exit code: 1`
=== STDOUT ===



=== STDERR ===
error[E0463]: can't find crate for `panic_abort` which `std` depends on
---
For more information about this error, try `rustc --explain E0463`.



"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "lib.rs" "-Cpanic=abort" "--sysroot" "./no_exists" "-L" "crate=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\panic_abort" "--target=i686-pc-windows-msvc"
output status: `exit code: 1`
=== STDOUT ===



=== STDERR ===
error[E0463]: can't find crate for `panic_abort` which `std` depends on
---



command failed at line 60
"D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\stage2\\bin\\rustc.exe" "-L" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "lib.rs" "-Cpanic=abort" "--sysroot" "./no_exists" "-L" "dependency=D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\panic_abort" "--target=i686-pc-windows-msvc"
output status: `exit code: 1`
=== STDOUT ===



=== STDERR ===
error: linking with `link.exe` failed: exit code: 1120
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\18\\Enterprise\\VC\\Tools\\MSVC\\14.51.36231\\bin\\HostX64\\x86\\link.exe" "/DEF:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\rustcyaQpqU\\lib.def" "/NOLOGO" "/LARGEADDRESSAWARE" "/SAFESEH" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\rustcyaQpqU\\symbols.o" "<1 object files omitted>" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\rustcyaQpqU\\rmeta.o" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out/libstd.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out\\panic_abort/libpanic_abort.rlib" "D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out/libcore.rlib" "/NXCOMPAT" "/LIBPATH:D:\\a\\rust\\rust\\build\\i686-pc-windows-msvc\\test\\run-make\\locate-panic-runtime\\rmake_out" "/OUT:lib.dll" "/OPT:REF,NOICF" "/DLL" "/IMPLIB:lib.dll.lib" "/DEBUG" "/PDBALTPATH:%_PDB%"
  = note: some arguments are omitted. use `--verbose` to show all linker arguments
  = note:    Creating library lib.dll.lib and object lib.dll.exp
          LINK : error LNK2001: unresolved external symbol __DllMainCRTStartup@12
          lib.dll : fatal error LNK1120: 1 unresolved externals
          

error: aborting due to 1 previous error
------------------------------------------

---
Currently active steps:
test::RunMake { test_compiler: Compiler { stage: 2, host: i686-pc-windows-msvc, forced_compiler: false }, target: i686-pc-windows-msvc } at src\bootstrap\src\core\build_steps\test.rs:1961
test::Compiletest { test_compiler: Compiler { stage: 2, host: i686-pc-windows-msvc, forced_compiler: false }, target: i686-pc-windows-msvc, mode: run-make, suite: "run-make", path: "tests/run-make", compare_mode: None } at src\bootstrap\src\core\build_steps\test.rs:1961
Build completed unsuccessfully in 1:48:29
make: *** [Makefile:115: ci-msvc-py] Error 1
  local time: Fri Jul 31 13:43:12 CUT 2026
  network time: Fri, 31 Jul 2026 13:43:16 GMT
##[error]Process completed with exit code 2.
##[group]Run echo "disk usage:"
echo "disk usage:"

rust-bors · 2026-07-31T13:50:52Z

PR #160007, which is a member of this rollup, was unapproved.

This rollup was thus unapproved.

rust-bors · 2026-07-31T14:48:03Z

💔 Test for bc4805a failed: CI. Failed jobs:

try - aarch64-apple (web logs, enhanced plaintext logs)
try - i686-msvc-1 (web logs, enhanced plaintext logs)
try - x86_64-msvc-1 (web logs, enhanced plaintext logs)

Kobzol and others added 30 commits July 27, 2026 10:39

Fix invalidation of stdlib in bootstrap when using non-LLVM codegen b…

216ee73

…ackends

add tests for loading injected crates

9e11f3c

remove hidden_glob_reexports

eeb4269

Update/remove lint attributes

a5963dc

fix query cycle in coroutine_hidden_types

0069ae1

Remove various superfluous lint attributes

c955c63

rustc_macros: ensure deterministic output

9a17150

Remove outdated comments from va_list.rs

41f5caa

Add test with fake and wrapped UnsafeCells

278132c

feat: parse cfg_select! within rustfmt

8c8a3d7

`cfg_select!` parsing needs to be implemented in rustfmt right now because there's no good way to call `rustc_attr_parsing::parse_cfg_select`.

chore: make rewrite_match_body pub(crate) within rustfmt

65fb2bb

The plan is to leverage `rewrite_match_body` to help with `cfg_select!` formatting.

feat: implement cfg_select! formatting in rustfmt

ea47e34

test: Add more cfg_select! test cases based on the PR review feedback

a932a6d

docs: Add doc comments based on PR feedback

d18984c

feat: flatten cfg_select! arms if they're a single expression

d32c7e9

test rejection of repeated rustc_on_unimplemented attributes

7f4e706

coalesce repeated on_unimplemented attributes

f21b64f

lint malformed rustc_on_unimplemented filters

9628fa5

rustdoc: Fix crash when trying to list attributes on an opaque type

c6d68c5

Add regression test for crash when generating index on opaque type

392b898

Update documentation about override-allocator setting

21d5748

Rename override-allocator setting to allocator as suggested by Ko…

45a0882

…bzol

Rename rust.allocator setting to build.allocator

7bfabd9

Add override-allocator changes to change tracker

b3ea12f

Fix list of options for build.allocator in bootstrap.example.toml

10b0ec6

Return Option<&str> from Allocator::feature_name()

91d43b4

support -Ldependency search paths for panic runtimes

b0811a0

tests: remove test for compiler_builtins

d1e25b4

refactor(attrs): move check_macro_only_attr into the attribute parsers

ccc55c3

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026

This comment has been minimized.

Sign in to view

JonathanBrouwer mentioned this pull request Jul 31, 2026

allow -Ldependency search paths for panic runtimes #160007

Open

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 31, 2026

JonathanBrouwer closed this Jul 31, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 31, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 31, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Rollup of 17 pull requests - #160278

Rollup of 17 pull requests#160278
JonathanBrouwer wants to merge 67 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-igu4ynF

JonathanBrouwer commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

JonathanBrouwer commented Jul 31, 2026

Uh oh!

JonathanBrouwer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

rust-bors Bot commented Jul 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants