Skip to content

Rename splat to rustc_splat in error messages - #160244

Open
teor2345 wants to merge 2 commits into
rust-lang:mainfrom
teor2345:extra-splat-renames
Open

Rename splat to rustc_splat in error messages#160244
teor2345 wants to merge 2 commits into
rust-lang:mainfrom
teor2345:extra-splat-renames

Conversation

@teor2345

@teor2345 teor2345 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Tracking issue: #153629

This PR renames "splat attribute" to "`rustc_splat` attribute" in error messages (and some comments).
It was meant to be part of #159817 but I missed it.

The search and replace command I used was:

fastmod --extensions rs --fixed-strings 'splat attribute' '`rustc_splat` attribute'

This doesn't need to be backported, because those error messages only appear on nightly.

Part of #159428

teor2345 added 2 commits July 31, 2026 13:34
…sages

fastmod --extensions rs --fixed-strings 'splat attribute' '`rustc_splat` attribute'
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 31, 2026
@rustbot

rustbot commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

r? @mati865

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 17 candidates

@teor2345

Copy link
Copy Markdown
Contributor Author

@rustbot label +A-attributes +A-macros +A-resolve +F-splat

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-resolve Area: Name/path resolution done by `rustc_resolve` specifically F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 labels Jul 31, 2026

@jieyouxu jieyouxu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not wrong!

splat attribute

Can mean both #[splat] and #[rustc_splat] 😉

Thanks
r? me @bors r+ rollup

View changes since this review

@rust-bors

rust-bors Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 8fa1e60 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 31, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-macros Area: All kinds of macros (custom derive, macro_rules!, proc macros, ..) A-resolve Area: Name/path resolution done by `rustc_resolve` specifically F-splat `#![feature(splat)]` https://github.com/rust-lang/rust/issues/153629 S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants