Rollup of 7 pull requests - #160213
Closed
JonathanBrouwer wants to merge 19 commits into
Closed
Conversation
Signed-off-by: Obei Sideg <obei.sideg@gmail.com>
Signed-off-by: Obei Sideg <obei.sideg@gmail.com>
This is a little more verbose than using a `[decode]` modifier, but will allow us to stop using higher-order macros when declaring arenas.
Follow-up to rust-lang#159990. This should cover all the files that I didn't get to reviewing in that PR.
Every caller can either get the kind from `builder.kind`, or directly match against variants of `Subcommand`. `Builder::new` is now the sole mapping from `Subcommand` to `Kind`.
…r=Urgau Add `raw_borrows_via_references` lint Close rust-lang#127724
…upported, r=Darksonn std: make positioned I/O unsupported on VxWorks Currently, build-std for VxWorks fails because std calls pread/pwrite for positioned I/O. Previously libc defined them as shims, but recently these were removed to align the actual state of SDK: rust-lang/libc#5129 It should make sense to return an unsupported error for VxWorks. Fix rust-lang/libc#5328
Stop using higher-order macros to declare arenas The arenas used by `rustc_hir` and `rustc_middle` are declared via macros. But instead of invoking `rustc_arena::declare_arena!` directly, those crates declare a higher-order macro containing a list of types, and then invoke that macro with `declare_arena!` as an argument. From what I can tell, the only reason for this arrangement is so that the list of types can also contain `[decode]` modifiers that produce a corresponding implementation of `RefDecodable` that decodes into the arena. But the number of types involved is small enough that it's easy to list them separately, and the advantage of doing so is that we can remove a layer of macro indirection, making it easier to navigate to the real code. There should be no change to compiler behaviour.
Derive `GenericTypeVisitable` for `RegionConstraint` Required for rust-analyzer, see [#t-compiler/rust-analyzer > Updating next-solver @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Updating.20next-solver/near/613430602)
…cote A few more "predicate"-to-"clause" renamings Follow-up to rust-lang#159990. This should cover all the files that I didn't get to reviewing in that PR. r? @nnethercote cc @oli-obk
…efore-close-brace, r=petrochenkov Fix ICE for parsing issue with a closing brace Fixes rust-lang#160171 r? @petrochenkov
bootstrap: Remove method `Subcommand::kind` Every caller can either get the kind from `builder.kind`, or directly match against variants of `Subcommand`. `Builder::new` is now the sole mapping from `Subcommand` to `Kind`.
rustbot
added
S-waiting-on-review
Contributor
Author
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
Rollup of 7 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 30, 2026
…uwer Rollup of 7 pull requests Successful merges: - #138230 (Add `raw_borrows_via_references` lint) - #160031 (std: make positioned I/O unsupported on VxWorks) - #159955 (Stop using higher-order macros to declare arenas) - #160164 (Derive `GenericTypeVisitable` for `RegionConstraint`) - #160177 (A few more "predicate"-to-"clause" renamings) - #160192 (Fix ICE for parsing issue with a closing brace) - #160209 (bootstrap: Remove method `Subcommand::kind`)
Contributor
rust-bors
Bot
added
S-waiting-on-review
Contributor
rust-bors
Bot
added
the
S-waiting-on-author
rustbot
removed
the
S-waiting-on-review
Contributor
|
This pull request was unapproved due to being closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
raw_borrows_via_referenceslint #138230 (Addraw_borrows_via_referenceslint)GenericTypeVisitableforRegionConstraint#160164 (DeriveGenericTypeVisitableforRegionConstraint)Subcommand::kind#160209 (bootstrap: Remove methodSubcommand::kind)r? @ghost
Create a similar rollup