Rollup of 8 pull requests

[JonathanBrouwer]

Successful merges:

• Rename splat to avoid stable name collisions #159817 (Rename splat to avoid stable name collisions)
• Don't escape U+FF9E and U+FF9F in escape_debug_ext #158057 (Don't escape U+FF9E and U+FF9F in escape_debug_ext)
• Resolve vars before calling unnormalized_obligations #159818 (Resolve vars before calling unnormalized_obligations)
• Split function parsing out of item.rs to a new module. #160040 (Split function parsing out of item.rs to a new module.)
• Add regression tests for fixed dead-code issues #160044 (Add regression tests for fixed dead-code issues)
• tests: Remove -Zthreads options from tests in ui/parallel-rustc #160147 (tests: Remove -Zthreads options from tests in ui/parallel-rustc)
• Try to recover less from incorrectly parsed const arg #160175 (Try to recover less from incorrectly parsed const arg)
• Mark Tuple and FnPtr traits #[fundamental] #160181 (Mark Tuple and FnPtr traits #[fundamental])

r? @ghost

Create a similar rollup

[JonathanBrouwer]

@bors r+ rollup=never p=5

[rust-bors]

📌 Commit 78ff3f1 has been approved by JonathanBrouwer

It is now in the queue for this repository.

[rust-bors]

💔 Test for 5b9c68b failed: CI. Failed job:

• auto - x86_64-gnu-parallel-frontend (web logs, enhanced plaintext logs)

[rust-log-analyzer]

The job x86_64-gnu-parallel-frontend failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

1 error[E0782]: expected a type, found a trait
+   --> $DIR/fn-sig-cycle-ice-153391.rs:6:15
+    |
+ LL |     fn g() -> B;
+    |               ^
+    |
+ help: `B` is dyn-incompatible, use `impl B` to return an opaque type, as long as you return a single underlying type
+    |
+ LL |     fn g() -> impl B;
+    |               ++++
+ 
+ error[E0782]: expected a type, found a trait
2   --> $DIR/fn-sig-cycle-ice-153391.rs:11:23
3    |
---
- LL |     fn g() -> impl B;
-    |               ++++
- help: alternatively, you can return an owned trait object
-    |
- LL |     fn g() -> Box<dyn B>;
-    |               +++++++  +
32 
33 error: aborting due to 2 previous errors
34 

Note: some mismatched output was normalized before being compared
-   --> /checkout/tests/ui/parallel-rustc/fn-sig-cycle-ice-153391.rs:6:15
+   --> $DIR/fn-sig-cycle-ice-153391.rs:6:15
+    |
+ LL |     fn g() -> B;
+    |               ^
+    |
+ help: `B` is dyn-incompatible, use `impl B` to return an opaque type, as long as you return a single underlying type
+    |
+ LL |     fn g() -> impl B;
+    |               ++++
+ 
+ error[E0782]: expected a type, found a trait

Compare output by lines enabled, diff by lines:
Expected contains these lines that are not in actual:
   |               +++++++  +
LL |     fn g() -> Box<dyn B>;
help: alternatively, you can return an owned trait object
help: use `impl B` to return an opaque type, as long as you return a single underlying type
Actual contains these lines that are not in expected:
help: `B` is dyn-incompatible, use `impl B` to return an opaque type, as long as you return a single underlying type

The actual stderr differed from the expected stderr
To update references, rerun the tests and pass the `--bless` flag
To only update this specific test, also pass `--test-args parallel-rustc/fn-sig-cycle-ice-153391.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/parallel-rustc/fn-sig-cycle-ice-153391.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(test,FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "-Zthreads=4" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/parallel-rustc/fn-sig-cycle-ice-153391" "-A" "unused" "-W" "unused_attributes" "-A" "internal_features" "-A" "incomplete_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2024"
stdout: none
--- stderr -------------------------------
error[E0782]: expected a type, found a trait
##[error]  --> /checkout/tests/ui/parallel-rustc/fn-sig-cycle-ice-153391.rs:6:15
   |
LL |     fn g() -> B;
   |               ^
   |
help: `B` is dyn-incompatible, use `impl B` to return an opaque type, as long as you return a single underlying type
   |
LL |     fn g() -> impl B;
   |               ++++

error[E0782]: expected a type, found a trait
---
   |
   = note: `A` is dyn-incompatible, otherwise a trait object could be used
help: use a new generic type parameter, constrained by `A`
   |
LL -     fn bar(&self, x: &A);
LL +     fn bar<T: A>(&self, x: &T);
   |
help: you can also use an opaque type, but users won't be able to specify the type parameter when calling the `fn`, having to rely exclusively on type inference
   |
LL |     fn bar(&self, x: &impl A);
   |                       ++++

Important

For more information how to resolve CI failures of this job, visit this link.

[Zalathar]

Is this a soft-conflict between #160147 and something else?

[rust-bors]

PR #160147, which is a member of this rollup, was unapproved.