make pad_i32 of PassMode::cast an integer - #160132
Conversation
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
ae7c1f7 to
b426b46
Compare
This comment has been minimized.
This comment has been minimized.
ee79d0f to
9de525c
Compare
so that we can specify more than one i32 of padding.
9de525c to
945f5d7
Compare
| fn reg_backend_type(&self, ty: &Reg) -> Type<'gcc> { | ||
| ty.gcc_type(self) | ||
| } |
There was a problem hiding this comment.
This is extrapolating from the LLVM implementation, it seems to work fine, cc @antoyo if there is something I'm missing.
| /// `pad_i32` indicates how many `Reg::i32()` dummy arguments are emitted before the real | ||
| /// argument. | ||
| Cast { pad_i32: u8, cast: Box<CastTarget> }, |
There was a problem hiding this comment.
I'm not sure about the name, but can't really think of anything obviously better but also somewhat short.
|
r? @bjorn3 |
|
cc @bjorn3 This PR changes rustc_public cc @oli-obk, @celinval, @ouz-a, @makai410
|
rustbot
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #160339) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
5 participants
so that we can specify more than one i32 of padding. This PR only adds the functionality but does not yet use it: there should be no functional changes.
This is needed for the ABI of
Complex<{ float }>on 32-bit powerpc. Other mechanisms, e.g. usingPassMode::prefixeddon't appear to work.More discussion is in #t-compiler/help > power complex abi.