Unimplement fmt::Debug for c_void - #160115
Conversation
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Unimplement `fmt::Debug` for `c_void`
This comment has been minimized.
This comment has been minimized.
Taking a shared reference to `c_void` is always wrong.
03942bc to
588c33e
Compare
|
@craterbot check |
|
👌 Experiment ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more |
|
Worth also commenting that there's a blanket (Regardless, it would be unsound to actually access data inside these pointers without verifying it's valid, but I could imagine some scenario where someone thought those only implemented |
Taking a shared reference to
c_voidis never correct, and this impl should never have been added.This is obviously a breaking change, so needs crater and FCP.
@rustbot label T-libs-api needs-fcp A-FFI
See also #159986, #159935