atomic volatile: add intrinsics - #160058
Conversation
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @oli-obk, @lcnr
cc @bjorn3
cc @rust-lang/miri |
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
|
library stuff looks fine, but the rest is not my prerogative :D r? compiler |
780cd0f to
faddba5
Compare
This comment has been minimized.
This comment has been minimized.
faddba5 to
7b5dd39
Compare
|
Cranelift doesn't currently have a way to do volatile memory operations. In the past this was not an issue given the lack of optimizations on memory operations, but those recently got added, so volatile support now needs to be added on the Cranelift side. |
This comment has been minimized.
This comment has been minimized.
7b5dd39 to
d51ce47
Compare
This comment has been minimized.
This comment has been minimized.
d51ce47 to
528983b
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Extend the atomic load/store intrinsics to also support volatile atomic load/store.
Tracking issue: #158947.
Library APIs that use these intrinsics will be added inn a future PR.
The GCC and cranelift implementations ignore the volatile flag, not sure how that should be implemented for them.