Move std::io::copy internals to alloc::io#158548
Open
bushrat011899 wants to merge 22 commits into
Open
Conversation
Used to work around `Cursor` not being a fundamental type when implementing `Write` for `Cursor<Vec<u8>>` and other `alloc` types once `Cursor` and `Write` are both located in `core`.
Call to `<&mut [u8] as Write>::write` inlined as `Write` trait not yet moved into `core`.
None of the currently public methods are accessible outside `std`, and are unused within. Therefore, they can be restricted to internal use.
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot blocked |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158547
Description
Moves the generic implementation of
std::io::copytoalloc::io. This is effectively a direct cut and paste. Blocked on #158547.Worth considering is how we may want to expose the generic copy function for end users. Currently,
stdonly exposesstd::io::copy, which internally useskernel_copyand falls back ontogeneric_copyas required. We could exposegeneric_copyasalloc::io::copy, but thenalloc::io::copyandstd::io::copywould be different functions. There are instances where that already happens (core::panic!is not the same asstd::panic!for example), but this would be an easy mistake to make with performance implications.Alternatively, EII could allow the
kernel_copyfunction to be provided toalloc, so the fullcopyfunction is defined inalloc::ioand then reexported instd::io. But that's dependent on EII being more stable.For now, this PR just moves
generic_copyto signal that the fullstd::io::copyis very close to being able to be moved intoalloc::io.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.