Move std::io::Write to core::io#158541
Open
bushrat011899 wants to merge 13 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @Darksonn rustbot has assigned @Darksonn. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot blocked |
rustbot
added
S-blocked
4 tasks
Used to work around `Cursor` not being a fundamental type when implementing `Write` for `Cursor<Vec<u8>>` and other `alloc` types once `Cursor` and `Write` are both located in `core`.
Call to `<&mut [u8] as Write>::write` inlined as `Write` trait not yet moved into `core`.
bushrat011899
force-pushed
the
core_io_write
branch
from
22e4295 to
802f7d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158537
Blocked On: #158540
Description
Moves
std::io::Writetocore::io. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved intoallocandcore. Blocked on #158537 and #158540.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.