-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
Move SizeHint and IoHandle to core::io
#158539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rust-bors
merged 4 commits into
rust-lang:main
from
bushrat011899:core_io_internal_traits
Jul 5, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| use crate::boxed::Box; | ||
| use crate::io::SizeHint; | ||
|
|
||
| // ============================================================================= | ||
| // Forwarding implementations | ||
|
|
||
| #[doc(hidden)] | ||
| #[unstable(feature = "core_io_internals", reason = "exposed only for libstd", issue = "none")] | ||
| impl<T> SizeHint for Box<T> { | ||
| #[inline] | ||
| fn lower_bound(&self) -> usize { | ||
| SizeHint::lower_bound(&**self) | ||
| } | ||
|
|
||
| #[inline] | ||
| fn upper_bound(&self) -> Option<usize> { | ||
| SizeHint::upper_bound(&**self) | ||
| } | ||
| } | ||
|
|
||
| // ============================================================================= | ||
| // In-memory buffer implementations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| use crate::io::SizeHint; | ||
|
|
||
| // ============================================================================= | ||
| // Forwarding implementations | ||
|
|
||
| #[doc(hidden)] | ||
| #[unstable(feature = "core_io_internals", reason = "exposed only for libstd", issue = "none")] | ||
| impl<T> SizeHint for &mut T { | ||
| #[inline] | ||
| fn lower_bound(&self) -> usize { | ||
| SizeHint::lower_bound(*self) | ||
| } | ||
|
|
||
| #[inline] | ||
| fn upper_bound(&self) -> Option<usize> { | ||
| SizeHint::upper_bound(*self) | ||
| } | ||
| } | ||
|
|
||
| // ============================================================================= | ||
| // In-memory buffer implementations | ||
|
|
||
| #[doc(hidden)] | ||
| #[unstable(feature = "core_io_internals", reason = "exposed only for libstd", issue = "none")] | ||
| impl SizeHint for &[u8] { | ||
| #[inline] | ||
| fn lower_bound(&self) -> usize { | ||
| self.len() | ||
| } | ||
|
|
||
| #[inline] | ||
| fn upper_bound(&self) -> Option<usize> { | ||
| Some(self.len()) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /// Internal trait used to allow for specialization in `Read::size_hint` and | ||
| /// `Iterator::size_hint`. | ||
| /// | ||
| /// All types implement this through a blanket default implementation returning | ||
| /// a hint of `(0, None)`. | ||
| /// | ||
| /// Implementors should only provide [`lower_bound`](SizeHint::lower_bound) and | ||
| /// [`upper_bound`](SizeHint::upper_bound). | ||
| /// [`size_hint`](SizeHint::size_hint) is provided as a `final` method to enforce | ||
| /// correctness. | ||
| #[doc(hidden)] | ||
| #[unstable(feature = "core_io_internals", reason = "exposed only for libstd", issue = "none")] | ||
| pub trait SizeHint { | ||
| /// Returns a lower bound on the number of elements this container-like item | ||
| /// contains. | ||
| /// For example, an array `[u8; 12]` could return any value between `0` and | ||
| /// `12` inclusively as a correct implementation. | ||
| /// | ||
| /// Through specialization, all types implement this method returning a default | ||
| /// value of `0`. | ||
| /// | ||
| /// Implementations *must* ensure the returned value is less than or equal to | ||
| /// the true element count. | ||
| fn lower_bound(&self) -> usize; | ||
|
|
||
| /// Returns an upper bound on the number of elements this container-like item | ||
| /// contains if it can be determined, otherwise `None`. | ||
| /// | ||
| /// Through specialization, all types implement this method returning a default | ||
| /// value of `None`. | ||
| /// | ||
| /// Implementations *must* ensure the returned value is greater than or equal | ||
| /// to the true element count. | ||
| fn upper_bound(&self) -> Option<usize>; | ||
|
|
||
| /// Returns an estimate for the number of elements this container like type | ||
| /// contains. | ||
| /// | ||
| /// This is a `final` method, and is guaranteed to return | ||
| /// `(self.lower_bound(), self.upper_bound())`. | ||
| /// | ||
| /// Without specialization, types implementing this trait will return `(0, None)`. | ||
| final fn size_hint(&self) -> (usize, Option<usize>) { | ||
| (self.lower_bound(), self.upper_bound()) | ||
| } | ||
| } | ||
|
|
||
| #[doc(hidden)] | ||
| #[unstable(feature = "core_io_internals", reason = "exposed only for libstd", issue = "none")] | ||
| impl<T: ?Sized> SizeHint for T { | ||
| #[inline] | ||
| default fn lower_bound(&self) -> usize { | ||
| 0 | ||
| } | ||
|
|
||
| #[inline] | ||
| default fn upper_bound(&self) -> Option<usize> { | ||
| None | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.