Fix typetree generation for differentiated functions#158333
Open
ZuseZ4 wants to merge 1 commit into
Open
Conversation
rustbot
added
A-LLVM
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
r? oli-obk |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
Doesn't look like Github CI will merge the previous PR anytime soon, so I'll add a few more features here in the meantime. |
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
typetrees-for-enzyme3
branch
2 times, most recently
from
3227538 to
64d9d50
Compare
This comment has been minimized.
This comment has been minimized.
…r generation for memcpy. This moves a TA failure in the testcase from memcpy to a later location.
ZuseZ4
force-pushed
the
typetrees-for-enzyme3
branch
from
64d9d50 to
75c0091
Compare
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further improvements after #158278
This fixes a test failure on main (encountered while working on the PR above) in
tests/codegen-llvm/autodiff/autodiffv2.rs.Further improvements are split out into #158440, with high-level docs available in rust-lang/rustc-dev-guide#2911
Also noticed that I can (probably?) remove the llvm_enzyme cfg at this point, #158460