Rename errors.rs file to diagnostics.rs (11/N)#157974
Open
GuillaumeGomez wants to merge 2 commits into
Open
Conversation
rustbot
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Jun 16, 2026
Contributor
There was a problem hiding this comment.
Github was very unhelpful with reviewing here, but managed to review the diff by making some manual diffs, looks good
@bors r+ rollup
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jun 16, 2026
… r=JonathanBrouwer Rename `errors.rs` file to `diagnostics.rs` (11/N) Follow-up of rust-lang#157485. This one is a bit different than the previous ones: it had both `diagnostics.rs` and `errors.rs` files, but both were switched compared to what the other compiler crates do (for `diagnostics.rs` in particular). So first we switched the two files, and then, to avoid confusion between `errors.rs` and `diagnostics.rs`, I renamed `errors.rs` into `error_helper.rs`. r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #157485.
This one is a bit different than the previous ones: it had both
diagnostics.rsanderrors.rsfiles, but both were switched compared to what the other compiler crates do (fordiagnostics.rsin particular). So first we switched the two files, and then, to avoid confusion betweenerrors.rsanddiagnostics.rs, I renamederrors.rsintoerror_helper.rs.r? @JonathanBrouwer