bootstrap: fix panic on empty CPU list in build metrics#157972
Open
SebTardif wants to merge 1 commit into
Open
bootstrap: fix panic on empty CPU list in build metrics#157972SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
SebTardif
force-pushed
the
fix-cpus-panic-metrics
branch
from
85ed3e6 to
6eb342a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
system.cpus()[0]panics with an index-out-of-bounds error whensysinfocannot detect any CPUs, which can happen in Docker containers with cgroup restrictions, minimal VMs, or CI runners with unusual configurations.This replaces the unchecked index with
.first()and a fallback to"unknown", matching the resilience of the adjacentcpu_threads_countfield which already handles the empty case correctly by reporting0.The original code was introduced in 70cdd7e (2022-06-04) as part of the build metrics system added in #93717.