Skip to content

Avoid dropping losing rustc_thread_pool scope panic payloads#157971

Open
kevin-valerio wants to merge 1 commit into
rust-lang:mainfrom
kevin-valerio:fix/issue-157969-thread-pool-scope-panic
Open

Avoid dropping losing rustc_thread_pool scope panic payloads#157971
kevin-valerio wants to merge 1 commit into
rust-lang:mainfrom
kevin-valerio:fix/issue-157969-thread-pool-scope-panic

Conversation

@kevin-valerio

Copy link
Copy Markdown

Fixes #157969

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 16, 2026
@rustbot

rustbot commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@bjorn3

bjorn3 commented Jun 16, 2026

Copy link
Copy Markdown
Member

std::thread::scope() aborts when dropping the panic payload panics rather than leaking the panic payload.

@petrochenkov

Copy link
Copy Markdown
Contributor

r? @bjorn3

@rustbot rustbot assigned bjorn3 and unassigned petrochenkov Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustc_thread_pool::scope can return before all scoped jobs finish if a later panic value panics on drop

4 participants