Emit a suggestion to cast the never type into a concrete type when it fails to satisfy an impl Trait bound#157966
Open
Muhtasim-Rasheed wants to merge 1 commit into
Conversation
… fails to satisfy an `impl Trait` bound
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
qaijuang
reviewed
Jun 16, 2026
Comment on lines
+4490
to
+4496
| let snippet = tcx.sess.source_map().span_to_snippet(span).unwrap(); | ||
| if span != expr.span { | ||
| err.help(format!( | ||
| "`!` can be coerced to any type; consider casting to a concrete type that implements the trait, e.g. \ | ||
| `{} as SomeType`", snippet | ||
| )); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| let snippet = tcx.sess.source_map().span_to_snippet(span).unwrap(); | |
| if span != expr.span { | |
| err.help(format!( | |
| "`!` can be coerced to any type; consider casting to a concrete type that implements the trait, e.g. \ | |
| `{} as SomeType`", snippet | |
| )); | |
| } | |
| if let Ok(snippet) = tcx.sess.source_map().span_to_snippet(span) | |
| && span != expr.span | |
| { | |
| err.help(format!( | |
| "`!` can be coerced to any type; consider casting to a concrete type that implements the trait, e.g. \ | |
| `{snippet} as SomeType`" | |
| )); | |
| } |
Member
|
@rustbot reroll |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157923