Function item should not be used as const arg#157962
Open
Shourya742 wants to merge 2 commits into
Open
Conversation
…ef const after scheduling. That works only when a later phase emits a real diagnostics. For function item (associated fn), the lowering needs parent trait and self args.
Collaborator
|
HIR ty lowering was modified cc @fmease |
Collaborator
|
|
Shourya742
commented
Jun 16, 2026
Comment on lines
+2794
to
+2800
| Res::Def(DefKind::AssocFn, _) => { | ||
| let guar = | ||
| self.dcx().span_err(span, "function items cannot be used as const arguments"); | ||
| Const::new_error(tcx, guar) | ||
| } | ||
| // FIXME(const_generics): create real const to allow fn items as const paths | ||
| Res::Def(DefKind::Fn | DefKind::AssocFn, did) => { | ||
| Res::Def(DefKind::Fn, did) => { |
Member
Author
There was a problem hiding this comment.
Previous both free function and associated function, where lowering to zero_sized fn def which would later emit diagnostics, but to lower the assoc it required the parent trait. This now emits an error, instead of lowering.
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #138088
r? @BoxyUwU