Test EII UI tests with prefer-dynamic by AsakuraMizu · Pull Request #156577 · rust-lang/rust

AsakuraMizu · 2026-05-14T16:06:57Z

Tracking issue: #125418

Remove no-prefer-dynamic from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs.

Tested with:

python3 x.py test tests/ui/eii --force-rerun

rustbot · 2026-05-14T16:07:03Z

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 73 candidates
Random selection from 17 candidates

mejrs

@bors r+ rollup

View changes since this review

rust-bors · 2026-05-14T20:35:56Z

📌 Commit 8f221d1 has been approved by mejrs

It is now in the queue for this repository.

…=mejrs Test EII UI tests with prefer-dynamic Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

…uwer Rollup of 6 pull requests Successful merges: - #155360 (map_try_insert changes) - #156493 (actually run the temp_dir doctest) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.)

…=mejrs Test EII UI tests with prefer-dynamic Tracking issue: rust-lang#125418 Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

…uwer Rollup of 8 pull requests Successful merges: - #156493 (actually run the temp_dir doctest) - #156452 (Implement pinned drop sugar) - #156600 (Make const param default test reproduce original ICE) - #156556 (Require UTF-8 in `Utf8Pattern::StringPattern`) - #156565 (delegation: emit error when self type is not specified and accessed) - #156577 (Test EII UI tests with prefer-dynamic) - #156586 (Use DropCtxt::new_block and new_block_with_statements systematically.) - #156587 (Correctly handle associated items in rustdoc macro expansion)

Zalathar · 2026-05-15T14:10:19Z

Failed in rollup? #156605 (comment)

@bors r-

rust-bors · 2026-05-15T14:10:28Z

This pull request was unapproved.

This PR was contained in a rollup (#156605), which was unapproved.

View changes since this unapproval

Zalathar · 2026-05-15T14:11:13Z

@bors try jobs=aarch64-apple

Test EII UI tests with prefer-dynamic try-job: aarch64-apple

rust-bors · 2026-05-15T15:13:28Z

💔 Test for 6b93d07 failed: CI. Failed job:

try - aarch64-apple (web logs, enhanced plaintext logs)

AsakuraMizu · 2026-05-15T18:23:38Z

😮 Oh I didn't expect it to fail on macOS. I'll look into it.

rust-bors · 2026-05-16T09:05:24Z

📌 Commit 124126e has been approved by mejrs

It is now in the queue for this repository.

A failed build status on this PR was cleared due to the approval.

Test EII UI tests with prefer-dynamic Tracking issue: #125418 Remove `no-prefer-dynamic` from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs. Fixes #151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

rust-bors · 2026-05-16T09:12:55Z

💔 Test for 4335cbf failed: CI. Failed job:

auto - dist-various-2 (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-05-16T09:17:15Z

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#13 DONE 23.8s

#14 [ 6/25] RUN apt-key adv --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.162 Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
#14 0.180 Executing: /tmp/apt-key-gpghome.9VMAJOvbkA/gpg.1.sh --batch --yes --keyserver keyserver.ubuntu.com --recv-keys 74DA7924C5513486
#14 0.942 gpg: key 74DA7924C5513486: public key "Igor Kozhukhov <igor@dilos.org>" imported
#14 0.946 gpg: Total number processed: 1
#14 0.946 gpg:               imported: 1
#14 DONE 1.0s

AsakuraMizu · 2026-05-16T10:01:50Z

It seems other PRs are also stuck here. 😂

Kobzol · 2026-05-16T18:55:49Z

@bors retry

Spurious failure fixed by #156640.

…=mejrs Test EII UI tests with prefer-dynamic Tracking issue: rust-lang#125418 Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

Rollup of 6 pull requests Successful merges: - #152852 (Remove driver_lint_caps) - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - #156518 ([style] rustfmt `match`es with comments in or-patterns) - #156596 (Split `LintExpectationId`s) - #156577 (Test EII UI tests with prefer-dynamic) - #156633 (Add regression test for issue #41261)

…=mejrs Test EII UI tests with prefer-dynamic Tracking issue: rust-lang#125418 Remove `no-prefer-dynamic` from the EII UI tests now that rust-lang#153648 fixed exporting EII declaration aliases from dylibs. Fixes rust-lang#151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

…uwer Rollup of 14 pull requests Successful merges: - #151742 (Remove redundant information in `rustc_abi::Variants`) - #151362 (Add interior-mutability suggestion to `static_mut_refs`) - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - #156208 (Emit retags in codegen to support BorrowSanitizer (part 1)) - #156596 (Split `LintExpectationId`s) - #156607 (ci: Update FreeBSD version to FreeBSD 14) - #156376 (suggest hex escapes for C-style escapes) - #156577 (Test EII UI tests with prefer-dynamic) - #156585 (explicit tail calls: ignore some tests on unsupported LLVM targets) - #156598 (Avoid rustfix suggestions for macro-expanded unused imports) - #156616 (rustdoc: add test case for `-Drustdoc::` and `--cap-lints`) - #156633 (Add regression test for issue #41261) - #156635 (rename unexpected_try_recover function) - #156636 (minor `rustc_mir_transform` cleanup)

…JonathanBrouwer,mu001999 Support defaults for static EIIs Tracking issue: rust-lang#125418 rust-lang#154193 added EII support for statics, but left default implementations for "a followup PR". This PR implements it. Maybe I should remove `no-prefer-dynamic` if rust-lang#156577 is accepted.

…uwer Rollup of 14 pull requests Successful merges: - #151742 (Remove redundant information in `rustc_abi::Variants`) - #151362 (Add interior-mutability suggestion to `static_mut_refs`) - #156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - #156208 (Emit retags in codegen to support BorrowSanitizer (part 1)) - #156596 (Split `LintExpectationId`s) - #156607 (ci: Update FreeBSD version to FreeBSD 14) - #156376 (suggest hex escapes for C-style escapes) - #156577 (Test EII UI tests with prefer-dynamic) - #156585 (explicit tail calls: ignore some tests on unsupported LLVM targets) - #156598 (Avoid rustfix suggestions for macro-expanded unused imports) - #156616 (rustdoc: add test case for `-Drustdoc::` and `--cap-lints`) - #156633 (Add regression test for issue #41261) - #156635 (rename unexpected_try_recover function) - #156636 (minor `rustc_mir_transform` cleanup)

Rollup merge of #156577 - AsakuraMizu:eii-default-dynamic, r=mejrs Test EII UI tests with prefer-dynamic Tracking issue: #125418 Remove `no-prefer-dynamic` from the EII UI tests now that #153648 fixed exporting EII declaration aliases from dylibs. Fixes #151271. Tested with: ```sh python3 x.py test tests/ui/eii --force-rerun ```

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#151742 (Remove redundant information in `rustc_abi::Variants`) - rust-lang/rust#151362 (Add interior-mutability suggestion to `static_mut_refs`) - rust-lang/rust#156121 (compiler: suggest `.collect()` when `String` is expected and `Iterator` is found) - rust-lang/rust#156208 (Emit retags in codegen to support BorrowSanitizer (part 1)) - rust-lang/rust#156596 (Split `LintExpectationId`s) - rust-lang/rust#156607 (ci: Update FreeBSD version to FreeBSD 14) - rust-lang/rust#156376 (suggest hex escapes for C-style escapes) - rust-lang/rust#156577 (Test EII UI tests with prefer-dynamic) - rust-lang/rust#156585 (explicit tail calls: ignore some tests on unsupported LLVM targets) - rust-lang/rust#156598 (Avoid rustfix suggestions for macro-expanded unused imports) - rust-lang/rust#156616 (rustdoc: add test case for `-Drustdoc::` and `--cap-lints`) - rust-lang/rust#156633 (Add regression test for issue rust-lang/rust#41261) - rust-lang/rust#156635 (rename unexpected_try_recover function) - rust-lang/rust#156636 (minor `rustc_mir_transform` cleanup)

rustbot assigned mejrs May 14, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026

AsakuraMizu mentioned this pull request May 14, 2026

Support defaults for static EIIs #156583

Open

mejrs approved these changes May 14, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2026

JonathanBrouwer mentioned this pull request May 15, 2026

Rollup of 6 pull requests #156590

Closed

JonathanBrouwer mentioned this pull request May 15, 2026

Rollup of 7 pull requests #156595

Closed

JonathanBrouwer mentioned this pull request May 15, 2026

Rollup of 7 pull requests #156601

Closed

JonathanBrouwer mentioned this pull request May 15, 2026

Rollup of 8 pull requests #156605

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 15, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request May 15, 2026

Auto merge of #156577 - AsakuraMizu:eii-default-dynamic, r=<try>

6b93d07

Test EII UI tests with prefer-dynamic try-job: aarch64-apple

This comment has been minimized.

Sign in to view

Test EII UI tests with prefer-dynamic

124126e

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 16, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2026

GuillaumeGomez mentioned this pull request May 16, 2026

Rollup of 6 pull requests #156652

Closed

JonathanBrouwer mentioned this pull request May 17, 2026

Rollup of 11 pull requests #156658

Closed

This was referenced May 17, 2026

Rollup of 9 pull requests #156663

Closed

Rollup of 14 pull requests #156670

Merged

rust-bors Bot merged commit 4babf87 into rust-lang:main May 18, 2026
11 of 12 checks passed

rustbot added this to the 1.97.0 milestone May 18, 2026

AsakuraMizu deleted the eii-default-dynamic branch May 18, 2026 10:03

Uh oh!

Conversation

AsakuraMizu commented May 14, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 14, 2026

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented May 14, 2026

Uh oh!

Zalathar commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented May 15, 2026

Uh oh!

Zalathar commented May 15, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 15, 2026

Uh oh!

This comment has been minimized.

AsakuraMizu commented May 15, 2026

Uh oh!

rust-bors Bot commented May 16, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented May 16, 2026

Uh oh!

rust-log-analyzer commented May 16, 2026

Uh oh!

AsakuraMizu commented May 16, 2026

Uh oh!

Kobzol commented May 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

AsakuraMizu commented May 14, 2026 •

edited by rustbot

Loading

mejrs left a comment •

edited by rustbot

Loading

Zalathar commented May 15, 2026 •

edited

Loading