Resolving Windows environment test failures#156562
Open
lms0806 wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| use crate::os::windows::fs::FileTimesExt; | ||
|
|
||
| let tmp = tmpdir(); | ||
| #[cfg(windows)] |
Contributor
There was a problem hiding this comment.
The cfgs are redundant, none of the other uses of got_symlink_permission use them.
Contributor
Author
There was a problem hiding this comment.
Then, do I just need to make sure that the test passes locally in a Windows environment as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves an issue where the
fs::tests::test_fs_set_times follows symlinkandfs::tests::test_fs_set_times_nofollowtests failed locally due to permission issues in a Windows environment.The code has been modified so that these tests do not proceed if permissions are not granted.
Since these tests can be passed with the necessary permissions via CI before merging, I believe it is appropriate for them to pass locally due to permission issues rather than fail.
Close #156558