Skip to content

fix issue-144595#156545

Open
bb1yd wants to merge 2 commits into
rust-lang:mainfrom
bb1yd:issue-144595
Open

fix issue-144595#156545
bb1yd wants to merge 2 commits into
rust-lang:mainfrom
bb1yd:issue-144595

Conversation

@bb1yd
Copy link
Copy Markdown
Contributor

@bb1yd bb1yd commented May 13, 2026

I close the previous PR because it's too messy

relevant issue:#144595

I fix this issue by calling look_ahead to check if the user write a name field in the tuple struct, then try to recover after calling parse_ty

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 13, 2026
@bb1yd bb1yd marked this pull request as ready for review May 13, 2026 12:22
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 13, 2026

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 13, 2026

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, parser
  • compiler, parser expanded to 73 candidates
  • Random selection from 16 candidates

@bb1yd bb1yd mentioned this pull request May 13, 2026
@qaijuang
Copy link
Copy Markdown
Contributor

No test ?

@rustbot

This comment has been minimized.

@bb1yd
Copy link
Copy Markdown
Contributor Author

bb1yd commented May 14, 2026

I have added a test. Thank you.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants