Skip to content

Rollup of 10 pull requests#156405

Merged
rust-bors[bot] merged 69 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-yJcad1j
May 10, 2026
Merged

Rollup of 10 pull requests#156405
rust-bors[bot] merged 69 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-yJcad1j

Conversation

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

Successful merges:

r? @ghost

Create a similar rollup

chorman0773 and others added 30 commits April 26, 2026 11:56
* Implement core::arch::return_address and tests

Fix typo

Apply suggestions from code review

Wording/docs changes.

Co-authored-by: Ralf Jung <post@ralfj.de>

Change signature according to Ralf's comment

Fix call to `core::intrinsics::return_address()` according to the new signature

Add cranelift implementation for intrinsic

Change wording on `return_address!()` to be clear that returning a null pointer is best-effort.

Fix formatting of doc comment

Fix mistake in cranelift codegen
* Do not generate llvm.returnaddress on wasm
* Supress return_address test on miri
Previously it only worked for bound and listening sockets and returned
an unspecified address otherwise.
This updates the rust-version file to 045b177.
…kname-for-connected-sockets

Add `getsockname` shim for connecting and connected sockets
avoid underflow in std::Instant when computing times before program startup
…-wsa-error-fix

Remove `WSAESHUTDOWN` workaround for network socket writes
This commit introduces `PassFailMode` as an internal detail of `TestProps`, but
the full migration is left to a subsequent commit.
Using those shims socket addresses can be created directly from
hostnames (e.g. using `ToSocketAddrs` from the standard library)
Add `getaddrinfo` and `freeaddrinfo` shims
This updates the rust-version file to 4ddd453.
This updates the rust-version file to 32bd660.
@rust-bors rust-bors Bot added the rollup A PR which is a rollup label May 10, 2026
@rustbot rustbot added A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 10, 2026
@JonathanBrouwer
Copy link
Copy Markdown
Contributor Author

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 10, 2026

📌 Commit cfd0d4c has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 10, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request May 10, 2026
Rollup of 10 pull requests


try-job: dist-various-1
try-job: test-various
try-job: x86_64-gnu-aux
try-job: x86_64-gnu-llvm-21-3
try-job: x86_64-msvc-1
try-job: aarch64-apple
try-job: x86_64-mingw-1
try-job: i686-msvc-2
@rust-bors

This comment has been minimized.

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 10, 2026

☀️ Try build successful (CI)
Build commit: 0da9b30 (0da9b30008e74299dbfd4f1ed68a8b76dcfaf553, parent: 99eed207b47aca1fec5c665531db8e948a92d0ca)

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 10, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 10, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 8m 54s
Pushing 4b0c9d7 to main...

@rust-bors rust-bors Bot merged commit 4b0c9d7 into rust-lang:main May 10, 2026
13 checks passed
@rustbot rustbot added this to the 1.97.0 milestone May 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing e8f92f5 (parent) -> 4b0c9d7 (this PR)

Test differences

Show 21 test diffs

Stage 1

  • [codegen] tests/codegen-llvm/intrinsics/return_address.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/output-format-doctest-emit.rs#dep-info: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/output-format-doctest-emit.rs#html-static-files: [missing] -> pass (J0)
  • [ui] tests/ui/proc-macro/closure-hir-span.rs: [missing] -> pass (J0)
  • [ui] tests/ui/reborrow/reborrow_let_match.rs: [missing] -> pass (J0)
  • fs::tests::test_rename_directory_to_non_empty_directory: [missing] -> pass (J1)
  • fs::tests::test_rename_file_over_open_file: [missing] -> pass (J1)
  • [codegen] tests/codegen-llvm/intrinsics/return_address.rs: [missing] -> ignore (ignored when the target family is wasm) (J6)

Stage 2

  • [ui] tests/rustdoc-ui/output-format-doctest-emit.rs#dep-info: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/output-format-doctest-emit.rs#html-static-files: [missing] -> pass (J2)
  • fs::tests::test_rename_directory_to_non_empty_directory: [missing] -> pass (J3)
  • fs::tests::test_rename_file_over_open_file: [missing] -> pass (J3)
  • [ui] tests/ui/proc-macro/closure-hir-span.rs: [missing] -> pass (J4)
  • [ui] tests/ui/reborrow/reborrow_let_match.rs: [missing] -> pass (J4)
  • [codegen] tests/codegen-llvm/intrinsics/return_address.rs: [missing] -> pass (J5)

Additionally, 6 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 4b0c9d76ae7d387229caea55cfa73c280b08b8a7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-musl: 1h 43m -> 2h 12m (+27.6%)
  2. dist-i686-msvc: 1h 47m -> 2h 16m (+26.2%)
  3. i686-msvc-2: 2h 17m -> 1h 42m (-25.5%)
  4. dist-powerpc64le-linux-gnu: 1h 16m -> 1h 36m (+25.5%)
  5. armhf-gnu: 1h 34m -> 1h 10m (-25.2%)
  6. dist-arm-linux-musl: 1h 20m -> 1h 39m (+24.2%)
  7. x86_64-mingw-1: 2h 12m -> 2h 42m (+23.0%)
  8. dist-x86_64-freebsd: 1h 31m -> 1h 11m (-22.3%)
  9. pr-check-1: 33m 30s -> 27m 23s (-18.3%)
  10. dist-x86_64-mingw: 2h 36m -> 2h 8m (-18.2%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#154972 Implement core::arch::return_address and tests af4b370aba01834a9916a2c1cda19d29634c371b (link)
#155679 rustdoc: Reify emission types 944fa8fa3f7b5e79118315d57e7a5d5b0fdb133a (link)
#155982 Fix closure HIR span context mismatch f68cbe5b79c60a6235a48ae10c98b483eb51e669 (link)
#156129 compiletest: Migrate from PassMode/FailMode to `PassFai… 092204d21eea7bdbb0ef6c0bba704742cd14c245 (link)
#156192 core: Replace ptr::slice_from_raw_parts with `slice::from… 685d17b59e96feeef1117ef6910904a25b51c202 (link)
#156323 Handle --print=backend-has-mnemonic in cg_clif 1e9f67c02a1961d39c34f16f74a943db94fea414 (link)
#156365 stream_send_recv_stress tests: wait for threads to finish 1027e0b38ad7f103d5682cda7a76a4ff4e77de01 (link)
#156368 Fix invalid unreachable in is_known_valid_scrutinee for Reb… ec10a1d945a6d131c85365c382dcd7b000d4c470 (link)
#156387 std fs tests: avoid matching on OS-provided error string 21efb7211a7cf6020b15423932a7fc5bb6805137 (link)
#156394 miri subtree update 757ccc33b2be5cdba133d92ba647bb425504cae7 (link)

previous master: e8f92f5769

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4b0c9d7): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -1.5%, secondary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)
-2.0% [-2.9%, -1.1%] 2
All ❌✅ (primary) -1.5% [-1.5%, -1.5%] 1

Cycles

Results (primary -2.1%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.0% [2.7%, 3.3%] 2
Improvements ✅
(primary)
-2.1% [-2.1%, -2.1%] 1
Improvements ✅
(secondary)
-3.6% [-5.0%, -2.1%] 2
All ❌✅ (primary) -2.1% [-2.1%, -2.1%] 1

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.1% [0.0%, 0.3%] 30
Regressions ❌
(secondary)
0.1% [0.0%, 0.1%] 19
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [0.0%, 0.3%] 30

Bootstrap: 501.011s -> 497.552s (-0.69%)
Artifact size: 397.14 MiB -> 397.27 MiB (0.03%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.