Skip to content

Fix invalid unreachable in is_known_valid_scrutinee for Reborrow#156368

Open
aapoalas wants to merge 2 commits intorust-lang:mainfrom
aapoalas:reborrow-in-match-statement
Open

Fix invalid unreachable in is_known_valid_scrutinee for Reborrow#156368
aapoalas wants to merge 2 commits intorust-lang:mainfrom
aapoalas:reborrow-in-match-statement

Conversation

@aapoalas
Copy link
Copy Markdown
Contributor

@aapoalas aapoalas commented May 9, 2026

Fixes #156304

Part of the Reborrow traits experiment #145612

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 9, 2026

Some changes occurred in match checking

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 9, 2026

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@rust-log-analyzer

This comment has been minimized.

Copy link
Copy Markdown
Member

@Nadrieril Nadrieril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, a reborrow is a value expression so that's a valid scrutinee

View changes since this review

@Nadrieril
Copy link
Copy Markdown
Member

r? me

@rustbot rustbot assigned Nadrieril and unassigned jieyouxu May 9, 2026
Comment thread tests/ui/reborrow/reborrow_let_match.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: "Reborrow expression in match"

5 participants