Implement derives for Reborrow and CoerceShared#156338
Open
P8L1 wants to merge 1 commit intorust-lang:mainfrom
Open
Implement derives for Reborrow and CoerceShared#156338P8L1 wants to merge 1 commit intorust-lang:mainfrom
P8L1 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
Collaborator
|
r? @tiif rustbot has assigned @tiif. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
c515771 to
1a83d37
Compare
This comment has been minimized.
This comment has been minimized.
1a83d37 to
8e2ead2
Compare
10 tasks
ChayimFriedman2
requested changes
May 9, 2026
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
8e2ead2 to
0d49f18
Compare
ChayimFriedman2
approved these changes
May 9, 2026
Contributor
Author
|
@rustbot ready |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds built-in derive support for the experimental
ReborrowandCoerceSharedmarker traits behind#![feature(reborrow)].The derives generate the same marker impls users would write manually, while preserving the existing coherence and structural validation path for the experimental reborrow traits.
Please note this impl:
CoerceSharedtarget type through the derive helper attribute.Part of #145612
Part of rust-lang/rust-project-goals#399