[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness` by Zalathar · Pull Request #153441 · rust-lang/rust

Zalathar · 2026-03-05T13:40:33Z

(Checking the perf impact of changing the cache_on_disk_if condition for this query, in the hopes that we can get rid of the only non-trivial condition in the query list.)

EDIT: Via #153487 (comment), the typeck query is another exception.

Zalathar · 2026-03-05T13:40:42Z

@bors try @rust-timer queue

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rust-bors · 2026-03-05T15:50:31Z

☀️ Try build successful (CI)
Build commit: c224af9 (c224af9741361284aa98ec8c1101471779b2465e, parent: 70d86e3abeecf3a655264d9a716c5d08160176b7)

rust-timer · 2026-03-05T17:39:09Z

Finished benchmarking commit (c224af9): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.1%, 0.3%]	14
Regressions ❌ (secondary)	0.6%	[0.2%, 1.1%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.2%	[0.1%, 0.3%]	14

Max RSS (memory usage)

Results (primary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.8%	[2.8%, 2.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-9.3%	[-9.3%, -9.3%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-3.2%	[-9.3%, 2.8%]	2

Cycles

Results (primary 2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

Results (secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	3
All ❌✅ (primary)	-	-	0

Bootstrap: 480.787s -> 479.846s (-0.20%)
Artifact size: 395.02 MiB -> 394.99 MiB (-0.01%)

Zalathar · 2026-03-05T22:57:36Z

Mostly-small regressions for always disk-caching.

Let's see what happens if we never disk-cache.

Zalathar · 2026-03-05T22:58:26Z

@bors try @rust-timer queue

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rust-bors · 2026-03-06T01:20:44Z

☀️ Try build successful (CI)
Build commit: ca5e9ad (ca5e9ad007adf8ad83b7981a7dbd37cf173447ba, parent: 64b72a1fa5449d928d5f553b01a596b78ee255d2)

rust-timer · 2026-03-06T02:01:09Z

Finished benchmarking commit (ca5e9ad): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.1%, 1.0%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -4.1%, secondary 1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.1%	[3.8%, 7.1%]	3
Improvements ✅ (primary)	-4.1%	[-5.9%, -2.4%]	2
Improvements ✅ (secondary)	-3.0%	[-3.9%, -2.3%]	3
All ❌✅ (primary)	-4.1%	[-5.9%, -2.4%]	2

Cycles

Results (primary 1.3%, secondary 4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.5%, 3.1%]	3
Regressions ❌ (secondary)	4.2%	[4.2%, 4.2%]	1
Improvements ✅ (primary)	-2.9%	[-2.9%, -2.9%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.3%	[-2.9%, 3.1%]	4

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.735s -> 480.871s (0.24%)
Artifact size: 395.00 MiB -> 397.01 MiB (0.51%)

Zalathar · 2026-03-06T13:12:58Z

Let's see what happens if we make typeck cache to disk for all keys.

@bors try @rust-timer queue

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rust-bors · 2026-03-06T15:22:49Z

☀️ Try build successful (CI)
Build commit: b770dfd (b770dfd7c9c71b443991c63ffb623b00eb2b5719, parent: f82485388963286763f8c8a9261ac227627f6a18)

rust-timer · 2026-03-06T16:03:09Z

Finished benchmarking commit (b770dfd): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	2.4%	[0.2%, 18.4%]	75
Regressions ❌ (secondary)	5.6%	[0.1%, 28.0%]	29
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	2.4%	[0.2%, 18.4%]	75

Max RSS (memory usage)

Results (primary 4.1%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.3%	[0.7%, 15.3%]	31
Regressions ❌ (secondary)	5.2%	[4.9%, 5.6%]	3
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-3.3%	[-4.5%, -2.1%]	2
All ❌✅ (primary)	4.1%	[-2.1%, 15.3%]	32

Cycles

Results (primary 3.6%, secondary 6.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.0%	[2.3%, 10.9%]	15
Regressions ❌ (secondary)	7.8%	[2.1%, 19.5%]	12
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	3.6%	[-2.2%, 10.9%]	16

Binary size

Results (primary 0.0%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.0%	[0.0%, 0.1%]	11
Regressions ❌ (secondary)	0.1%	[0.0%, 0.2%]	16
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.0%	[0.0%, 0.1%]	11

Bootstrap: 480.442s -> 481.212s (0.16%)
Artifact size: 397.10 MiB -> 395.19 MiB (-0.48%)

Zalathar · 2026-03-06T23:36:49Z

Always caching typeck on disk looks quite bad.

What if we never cache it to disk?

@bors try @rust-timer queue

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rust-log-analyzer · 2026-03-07T00:12:52Z

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

/dev/sda15       98M  6.4M   92M   7% /boot/efi
tmpfs           1.6G   16K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (120768024KB >= 52428800KB). Skipping cleanup.
##[group]Run echo "[CI_PR_NUMBER=$num]"
echo "[CI_PR_NUMBER=$num]"
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip compiler \
  --skip src
#!/bin/bash

set -ex

# Run a subset of tests. Used to run tests in parallel in multiple jobs.

# When this job partition is run as part of PR CI, skip tidy to allow revealing more failures. The
# dedicated `tidy` job failing won't block other PR CI jobs from completing, and so tidy failures
# shouldn't inhibit revealing other failures in PR CI jobs.
if [ "$PR_CI_JOB" == "1" ]; then
  echo "PR_CI_JOB set; skipping tidy"
  SKIP_TIDY="--skip tidy"
fi

../x.py --stage 2 test \
  ${SKIP_TIDY:+$SKIP_TIDY} \
  --skip tests \
  --skip coverage-map \
  --skip coverage-run \
  --skip library \
  --skip tidyselftest
---
##[endgroup]
Executing "/scripts/stage_2_test_set1.sh"
+ /scripts/stage_2_test_set1.sh
+ '[' 1 == 1 ']'
+ echo 'PR_CI_JOB set; skipping tidy'
+ SKIP_TIDY='--skip tidy'
PR_CI_JOB set; skipping tidy
+ ../x.py --stage 2 test --skip tidy --skip compiler --skip src
##[group]Building bootstrap
    Finished `dev` profile [unoptimized] target(s) in 0.04s
##[endgroup]
downloading https://static.rust-lang.org/dist/2026-01-21/rustfmt-nightly-aarch64-unknown-linux-gnu.tar.xz
---
test [ui] tests/ui/abi/abi-sysv64-register-usage.rs ... ignored, ignored when the architecture is aarch64
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_disabled ... ok
test [ui] tests/ui/abi/abi-typo-unstable.rs#feature_enabled ... ok
test [ui] tests/ui/abi/anon-extern-mod.rs ... ok
test [ui] tests/ui/abi/avr-sram.rs#disable_sram ... ok
test [ui] tests/ui/abi/avr-sram.rs#has_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#aarch64 ... ok
test [ui] tests/ui/abi/avr-sram.rs#no_sram ... ok
test [ui] tests/ui/abi/arm-unadjusted-intrinsic.rs#arm ... ok
test [ui] tests/ui/abi/bad-custom.rs ... ok
test [ui] tests/ui/abi/c-stack-as-value.rs ... ok
test [ui] tests/ui/abi/c-zst.rs#aarch64-darwin ... ok
test [ui] tests/ui/abi/c-zst.rs#powerpc-linux ... ok
---
test [ui] tests/ui/asm/aarch64/ttbr0_el2.rs ... ok
test [ui] tests/ui/asm/aarch64/type-check-2.rs ... ok
test [ui] tests/ui/asm/aarch64/type-check-3.rs ... ok
test [ui] tests/ui/asm/aarch64/type-f16.rs ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#hf ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#r82 ... ok
test [ui] tests/ui/asm/aarch64v8r.rs#sf ... ok
test [ui] tests/ui/asm/aarch64/sym.rs ... ok
test [ui] tests/ui/asm/arm-low-dreg.rs ... ok
test [ui] tests/ui/asm/binary_asm_labels.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/asm/asm-with-nested-closure.rs ... ok
test [ui] tests/ui/asm/bad-template.rs#aarch64 ... ok
---
test [ui] tests/ui/const-generics/occurs-check/unused-substs-2.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-3.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-4.rs ... ok
test [ui] tests/ui/const-generics/occurs-check/unused-substs-5.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic.rs ... ok
test [ui] tests/ui/const-generics/ogca/basic-fail.rs ... ok
test [ui] tests/ui/const-generics/ogca/generic-param-rhs.rs ... ok
test [ui] tests/ui/const-generics/ogca/coherence-ambiguous.rs ... ok
test [ui] tests/ui/const-generics/ogca/rhs-but-not-root.rs ... ok
test [ui] tests/ui/const-generics/opaque_types.rs ... ok
test [ui] tests/ui/const-generics/outer-lifetime-in-const-generic-default.rs ... ok
test [ui] tests/ui/const-generics/overlapping_impls.rs ... ok
test [ui] tests/ui/const-generics/opaque_types2.rs ... ok
test [ui] tests/ui/const-generics/params-in-ct-in-ty-param-lazy-norm.rs#full ... ok
---
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat2 ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#fat3 ... ok
test [ui] tests/ui/extern/issue-80074.rs ... ok
test [ui] tests/ui/extern/issue-95829.rs ... ok
test [ui] tests/ui/extern/lgamma-linkage.rs ... ok
test [ui] tests/ui/extern/issue-64655-extern-rust-must-allow-unwind.rs#thin1 ... ok
test [ui] tests/ui/extern/not-in-block.rs ... ok
test [ui] tests/ui/extern/unsized-extern-derefmove.rs ... ok
test [ui] tests/ui/extern/no-mangle-associated-fn.rs ... ok
test [ui] tests/ui/feature-gates/allow-features-empty.rs ... ok
---
test [ui] tests/ui/feature-gates/feature-gate-macro-derive.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-macro-metavar-expr-concat.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-marker_trait_attr.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-may-dangle.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-mgca-type-const-syntax.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-min-generic-const-args.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-movrs_target_feature.rs ... ignored, only executed when the architecture is x86_64
test [ui] tests/ui/feature-gates/feature-gate-min_const_fn.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-more-maybe-bounds.rs ... ok
test [ui] tests/ui/feature-gates/feature-gate-naked_functions_rustic_abi.rs ... ignored, only executed when the architecture is x86_64
---
test [ui] tests/ui/imports/ambiguous-9.rs ... ok
test [ui] tests/ui/imports/ambiguous-import-visibility-module.rs ... ok
test [ui] tests/ui/imports/ambiguous-glob-vs-expanded-extern.rs ... ok
test [ui] tests/ui/imports/ambiguous-8.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-glob-vs-multiouter.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-globvsglob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-no-implicit-prelude.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-core-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-non-prelude-std-glob.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-core.rs ... ok
test [ui] tests/ui/imports/ambiguous-panic-pick-std.rs ... ok
---
test [ui] tests/ui/layout/randomize.rs#normal ... ok
test [ui] tests/ui/layout/post-mono-layout-cycle.rs ... ok
test [ui] tests/ui/layout/randomize.rs#randomize-layout ... ok
test [ui] tests/ui/layout/null-pointer-optimization.rs ... ok
test [ui] tests/ui/layout/rigid-alias-due-to-broken-impl.rs ... ok
test [ui] tests/ui/layout/size-of-val-raw-too-big.rs ... ignored, only executed when the pointer width is 32bit (Layout computation rejects this layout for different reasons on 64-bit.)
test [ui] tests/ui/layout/struct.rs ... ok
test [ui] tests/ui/layout/reprc-power-alignment.rs ... ok
test [ui] tests/ui/layout/rust-call-abi-not-a-tuple-ice-81974.rs ... ok
test [ui] tests/ui/layout/rigid-alias-no-params.rs ... ok
---

---- [incremental] tests/incremental/change_private_fn/struct_point.rs stdout ----
------rustc stdout------------------------------

------rustc stderr------------------------------
{"$message_type":"diagnostic","message":"`typeck(fn_calls_methods_in_same_impl::check)` should have been loaded from disk but it was not","code":null,"level":"error","spans":[{"file_name":"/checkout/tests/incremental/change_private_fn/struct_point.rs","byte_start":1822,"byte_end":1836,"line_start":59,"line_end":59,"column_start":5,"column_end":19,"is_primary":true,"text":[{"text":"    pub fn check() {","highlight_start":5,"highlight_end":19}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[],"rendered":"error: `typeck(fn_calls_methods_in_same_impl::check)` should have been loaded from disk but it was not\n  --> /checkout/tests/incremental/change_private_fn/struct_point.rs:59:5\n   |\nLL |     pub fn check() {\n   |     ^^^^^^^^^^^^^^\n\n"}
{"$message_type":"diagnostic","message":"aborting due to 1 previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to 1 previous error\n\n"}

------------------------------------------

error in revision `cfail2`: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/incremental/change_private_fn/struct_point.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/aarch64-unknown-linux-gnu/stage2" "--target=aarch64-unknown-linux-gnu" "--cfg" "cfail2" "--check-cfg" "cfg(test,FALSE,cfail1,cfail2)" "-C" "incremental=/checkout/obj/build/aarch64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point/struct_point.inc" "-Z" "incremental-verify-ich" "-O" "--error-format" "json" "--json" "future-incompat" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/aarch64-unknown-linux-gnu/test/incremental/change_private_fn/struct_point" "-A" "internal_features" "-A" "unused_parens" "-A" "unused_braces" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/aarch64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "query-dep-graph"
stdout: none
--- stderr -------------------------------
error: `typeck(fn_calls_methods_in_same_impl::check)` should have been loaded from disk but it was not
##[error]  --> /checkout/tests/incremental/change_private_fn/struct_point.rs:59:5
   |
LL |     pub fn check() {
   |     ^^^^^^^^^^^^^^

rust-bors · 2026-03-07T01:48:34Z

☀️ Try build successful (CI)
Build commit: 3657032 (365703221cd8cf715cf4b285d1be2732323fae40, parent: 80282b130679a654eaa22f028a908c51be53d436)

rust-timer · 2026-03-07T02:29:09Z

Finished benchmarking commit (3657032): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	32.5%	[0.1%, 104.2%]	72
Regressions ❌ (secondary)	17.5%	[0.1%, 88.6%]	27
Improvements ✅ (primary)	-2.8%	[-8.1%, -0.1%]	83
Improvements ✅ (secondary)	-2.2%	[-8.1%, -0.1%]	102
All ❌✅ (primary)	13.6%	[-8.1%, 104.2%]	155

Max RSS (memory usage)

Results (primary 5.9%, secondary -1.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	11.3%	[3.4%, 22.7%]	64
Regressions ❌ (secondary)	4.4%	[2.2%, 6.9%]	11
Improvements ✅ (primary)	-3.0%	[-5.5%, -1.3%]	39
Improvements ✅ (secondary)	-4.4%	[-8.1%, -1.5%]	20
All ❌✅ (primary)	5.9%	[-5.5%, 22.7%]	103

Cycles

Results (primary 23.5%, secondary 7.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	43.7%	[4.6%, 107.5%]	65
Regressions ❌ (secondary)	26.0%	[3.3%, 79.7%]	16
Improvements ✅ (primary)	-4.5%	[-9.2%, -2.3%]	47
Improvements ✅ (secondary)	-4.8%	[-6.5%, -2.3%]	23
All ❌✅ (primary)	23.5%	[-9.2%, 107.5%]	112

Binary size

Results (primary -0.1%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	8
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Bootstrap: 482.9s -> 483.826s (0.19%)
Artifact size: 397.22 MiB -> 395.16 MiB (-0.52%)

Zalathar · 2026-03-07T02:40:58Z

Unfortunately, these perf results make it clear that the unusual cache-on-disk condition of typeck can't be easily simplified or removed.

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 5, 2026

Auto merge of #153441 - Zalathar:no-liveness, r=<try>

c224af9

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2026

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 5, 2026

Zalathar force-pushed the no-liveness branch from 29ffc35 to 5829037 Compare March 5, 2026 22:58

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 5, 2026

rust-bors bot pushed a commit that referenced this pull request Mar 5, 2026

Auto merge of #153441 - Zalathar:no-liveness, r=<try>

ca5e9ad

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

This comment has been minimized.

Sign in to view

rustbot removed S-waiting-on-perf Status: Waiting on a perf run to be completed. perf-regression Performance regression. labels Mar 6, 2026

Zalathar mentioned this pull request Mar 6, 2026

Simplify the cache_on_disk_if query modifier to just cache_on_disk #153487

Closed

Zalathar force-pushed the no-liveness branch from 5829037 to 0e36e99 Compare March 6, 2026 13:11

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026

Auto merge of #153441 - Zalathar:no-liveness, r=<try>

b770dfd

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 6, 2026

Make the typeck query never cache to disk

ae62efc

Zalathar force-pushed the no-liveness branch from 0e36e99 to ae62efc Compare March 6, 2026 23:36

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 6, 2026

Auto merge of #153441 - Zalathar:no-liveness, r=<try>

3657032

[EXPERIMENT] Cache-on-disk perf experiments for `check_liveness`

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 6, 2026

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 7, 2026

Zalathar closed this Mar 7, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 7, 2026

Zalathar deleted the no-liveness branch March 7, 2026 02:41

Uh oh!

Conversation

Zalathar commented Mar 5, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 5, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 5, 2026

Overall result: ❌ regressions - please read the text below

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

Zalathar commented Mar 5, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 6, 2026

Overall result: ❌ regressions - no action needed

Uh oh!

Zalathar commented Mar 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Mar 6, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 6, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Zalathar commented Mar 6, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Mar 7, 2026

Uh oh!

rust-bors bot commented Mar 7, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Mar 7, 2026

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Zalathar commented Mar 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Zalathar commented Mar 5, 2026 •

edited by rustbot

Loading