Simplify size/align_of_val<T: Sized> to size/align_of<T> instead#152689
Simplify size/align_of_val<T: Sized> to size/align_of<T> instead#152689rust-bors[bot] merged 2 commits intorust-lang:mainfrom
size/align_of_val<T: Sized> to size/align_of<T> instead#152689Conversation
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Simplify `size/align_of_val<T: Sized>` to `size/align_of<T>` instead
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (85c1367): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary -2.4%, secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.3%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 482.657s -> 485.908s (0.67%) |
|
r? @cjgillot |
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
@bors r+ |
This comment has been minimized.
This comment has been minimized.
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 7f99507 (parent) -> ef70767 (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ef70767064ab87b0a41400f69e1dc0b55c8d5284 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (ef70767): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResults (primary -0.0%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 481.508s -> 496.246s (3.06%) |
Same as rust-lang#152689 did for align/size.
This is relevant to things like
Box<[u8; 1024]>where the drop looks at thesize_of_val(since obviously it might be DST in general) but where we don't actually need to do that since it's always that same value for theSizedtype.(Equivalent to #152681, but flipped in the rebase so it can land before #152641 instead of depending on it.)