Merged
Conversation
Collaborator
|
(rustbot has picked a reviewer for you, use r? to override) |
Collaborator
|
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
stdarch_update
branch
from
df77ee2 to
f245f4d
Compare
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
stdarch_update
branch
from
f245f4d to
9a4c962
Compare
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
stdarch_update
branch
from
9a4c962 to
4172de1
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
This comment has been minimized.
This comment has been minimized.
Amanieu
force-pushed
the
stdarch_update
branch
from
598a1e5 to
edabf95
Compare
This comment has been minimized.
This comment has been minimized.
Amanieu
added a commit
to Amanieu/aHash
that referenced
this pull request
Nov 1, 2023
This is blocking rust-lang/rust#117372, which replaces `stdsimd` with more fine-grained features. However the auto-detection in aHash breaks when bootstrapping Rust because it detects the `stdsimd` feature on the old toolchain which is not present on the newly build libcore. This PR removes the build-time detection of the `stdsimd` feature and instead just uses the ARM AES intrinsics directly since they are now stable, but only on AArch64.
Amanieu
force-pushed
the
stdarch_update
branch
from
edabf95 to
a46fb3c
Compare
This comment has been minimized.
This comment has been minimized.
Mark-Simulacrum
added
S-waiting-on-author
tkaitchuck
pushed a commit
to tkaitchuck/aHash
that referenced
this pull request
Nov 10, 2023
* Remove build-time check for `stdsimd` feature This is blocking rust-lang/rust#117372, which replaces `stdsimd` with more fine-grained features. However the auto-detection in aHash breaks when bootstrapping Rust because it detects the `stdsimd` feature on the old toolchain which is not present on the newly build libcore. This PR removes the build-time detection of the `stdsimd` feature and instead just uses the ARM AES intrinsics directly since they are now stable, but only on AArch64. * Add nightly-arm-aes Cargo feature
Contributor
|
AHash just released a new version, so this should be unblocked now. |
Amanieu
force-pushed
the
stdarch_update
branch
from
a46fb3c to
40d1a05
Compare
Member
|
Your When Rust 1.78 becomes stable, it will still work. It's just broken on nightlies. This is a typical issue with this kind of "nightly feature auto-detection", and it shows why doing such auto detection is a bad idea. |
Member
|
Oh, I understand. Thank you for explaining :) |
This was referenced Feb 6, 2024
vadorovsky
added a commit
to Lightprotocol/light-protocol
that referenced
this pull request
Feb 6, 2024
The newest Rust nightly removed the `stdsimd` feature in favor of more grained features (rust-lang/rust#117372). However, the version of `ahash` we depend on, still requires that feature. New release of `ahash` (0.8.7) contains a fix, but we can't upgrade to it without upgrading Anchor. Pinning Rust nightly seems to be the less intrusive solution for now.
vadorovsky
added a commit
to Lightprotocol/light-protocol
that referenced
this pull request
Feb 6, 2024
The newest Rust nightly removed the `stdsimd` feature in favor of more grained features (rust-lang/rust#117372). However, the version of `ahash` we depend on, still requires that feature. New release of `ahash` (0.8.7) contains a fix, but we can't upgrade to it without upgrading Anchor. Pinning Rust nightly seems to be the less intrusive solution for now.
ananas-block
pushed a commit
to Lightprotocol/light-protocol
that referenced
this pull request
Feb 6, 2024
The newest Rust nightly removed the `stdsimd` feature in favor of more grained features (rust-lang/rust#117372). However, the version of `ahash` we depend on, still requires that feature. New release of `ahash` (0.8.7) contains a fix, but we can't upgrade to it without upgrading Anchor. Pinning Rust nightly seems to be the less intrusive solution for now.
IceTDrinker
added a commit
to IceTDrinker/pulp
that referenced
this pull request
Feb 8, 2024
sarah-quinones
pushed a commit
to sarah-quinones/pulp
that referenced
this pull request
Feb 8, 2024
…ly (#6) * use newly introduced stdarch features for avx512 to compiler on nightly see rust-lang/rust#117372 * bump version to 0.18.7
2 tasks
This was referenced Feb 16, 2024
paultag
added a commit
to KittyCAD/modeling-app
that referenced
this pull request
Feb 22, 2024
Specifically, i'm hitting tkaitchuck/aHash#200 ahash FTBFS because of rust-lang/rust#117372 which is fixed in 0.8.7. This rolls us forward which should fix future builds.
6 tasks
Closed
1 task
This was referenced Nov 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits up #27731 into multiple tracking issues.
Closes #27731