Skip to content

Mention that the [lock] hander is enabled org-wide#1058

Open
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:lock-org-wide
Open

Mention that the [lock] hander is enabled org-wide#1058
Urgau wants to merge 1 commit into
rust-lang:masterfrom
Urgau:lock-org-wide

Conversation

@Urgau
Copy link
Copy Markdown
Member

@Urgau Urgau commented May 30, 2026

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2026
Comment thread src/triagebot/lock.md
Comment on lines +31 to 34
> [!NOTE]
> This feature is [enabled by default](https://github.com/rust-lang/triagebot/blob/master/rust-lang.triagebot.toml) in the rust-lang organization.

This feature is enabled on a repository by having a `[lock]` table in `triagebot.toml`:
Copy link
Copy Markdown
Contributor

@apiraino apiraino May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm slightly confused, I feel these two sentences are now contradicting each other but maybe I am missing something.

What does rust-lang/triagebot@a4fd51b actually do? Do individual repositories need to enable the flag with [lock] in their triagebot.toml or is now the feature already enabled by default in the whole GH rust-lang (i.e. it's an opt-out flag)? If the flag is opt-out, maybe we should document how to add exception.

View changes since the review

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same message added to all the org-wide enabled handlers (see #1045).

What does rust-lang/triagebot@a4fd51b actually do?

It enables the [lock] handler for the repositories that have a triagebot.toml without having them to manually add it to their triagebot.toml.

maybe we should document how to add exception

The opt-out mechanism is described in the rust-lang.triagebot.toml.

Copy link
Copy Markdown
Member Author

@Urgau Urgau May 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm slightly confused, I feel these two sentences are now contradicting each other but maybe there I am missing something.

I don't think they contradict each other.

The first one informs that it's enabled org-wide, the rest is normal description on how to enable it manually, which is particularly useful for handlers that have options (not this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants