Do not use dyn HirDatabase, only dyn SourceDatabase - #22968
Open
ChayimFriedman2 wants to merge 7 commits into
Open
Do not use dyn HirDatabase, only dyn SourceDatabase#22968ChayimFriedman2 wants to merge 7 commits into
dyn HirDatabase, only dyn SourceDatabase#22968ChayimFriedman2 wants to merge 7 commits into
Conversation
I authored a script to use rust-analyzer's own autoimport assist to do that automatically on all files. Then added manually two more imports in interner.rs because the script didn't handle multiple modules in one file correctly.
- Implement `as_dyn()` for DBs - Remove usage of `as_dyn()` in tests, it's now a compile error - Replace `HirDatabase::zalsa_register_downcaster()` with `SourceDatabase::zalsa_register_downcaster()`
rustbot
added
the
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (possibly #22966) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To save a virtual call.
Reviewing commit-by-commit is recommended. The commit messages are also important.