fix: include all lifetimes in doctest runnable filters - #22848
Open
AayushMainali-Github wants to merge 1 commit into
Open
fix: include all lifetimes in doctest runnable filters#22848AayushMainali-Github wants to merge 1 commit into
AayushMainali-Github wants to merge 1 commit into
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
Please note that our AI policy disallows using AI to write GitHub comments, including PR descriptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22830
Doctest runnable filters for associated items only included the first lifetime parameter of the implementing ADT. For types with multiple lifetimes, that produced filters like
Foo<'a>::methodwhile rustc names the doctestFoo<'a,'b>::method, so "Run Doctest" ran 0 tests.Collect all early-bound lifetimes in
Adt::lifetimes/Type::generic_parametersso the generated filter matches rustc.Test plan
cargo test -p ide --lib runnables::cargo test -p ide-diagnostics --lib unresolved_methodcargo clippy -p hir -p ide --lib -- -D warningsAI disclosure: Assisted by Cursor (Grok).