Fix parser stack overflow#22513
Open
sunny026 wants to merge 2 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-review
| r: Restrictions, | ||
| bp: u8, | ||
| ) -> Option<(CompletedMarker, BlockLike)> { | ||
| if !p.check_recursion_limit() { |
Contributor
There was a problem hiding this comment.
This is, of course, not enough. Many functions in the parser recurse.
I'm not yet sure whether we want such thing, though.
Member
There was a problem hiding this comment.
if we want to fix this we should do what rustc does which is growing the stack on demand
Contributor
There was a problem hiding this comment.
And there are also plenty of places besides parsing that will need that (although parsing is the most important).
Member
There was a problem hiding this comment.
Yea hir-def lowering does as well at the very least
Contributor
|
Wait, did you even check that it is parsing that stack overflows on this code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.