fix: don't complete .await on receivers of unknown type#22486
Open
ada4a wants to merge 3 commits into
Open
Conversation
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-review
ChayimFriedman2
requested changes
May 30, 2026
| env: ParamEnvAndCrate<'db>, | ||
| trait_: TraitId, | ||
| ) -> bool { | ||
| if ty.is_ty_error() { |
Contributor
There was a problem hiding this comment.
This should come in implements_trait_unique_with_infcx().
ada4a
force-pushed
the
22478-spurious-await
branch
from
21a8536 to
fd4b9ff
Compare
rustbot
added
the
S-waiting-on-review
ada4a
force-pushed
the
22478-spurious-await
branch
from
fd4b9ff to
dac2dfe
Compare
ada4a
force-pushed
the
22478-spurious-await
branch
from
dac2dfe to
0f3c0ec
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #22448) made this pull request unmergeable. Please resolve the merge conflicts. |
Veykril
approved these changes
Jun 6, 2026
| } | ||
|
|
||
| #[test] | ||
| fn no_await_on_error_type() { |
Member
There was a problem hiding this comment.
lets move this test into crates\ide-completion\src\tests\expression.rs (at one point I tried getting rid of the unit tests in the completions directory, grouping them by "location" instead, but I never managed to finish that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22478
This also happens to improve syntax highlighting in presence of error types, and therefore fixes #22487