Skip to content

feat: add public Refdb type #1228

Open
bordumb wants to merge 2 commits intorust-lang:masterfrom
bordumb:bordumb/refDbType
Open

feat: add public Refdb type #1228
bordumb wants to merge 2 commits intorust-lang:masterfrom
bordumb:bordumb/refDbType

Conversation

@bordumb
Copy link
Copy Markdown
Contributor

@bordumb bordumb commented Mar 27, 2026

Overview

This is a followup PR to this one:
#1221

Specifically addressing the comment from @ehuss here:
#1221 (review)

2 additions:

  • The aim is to add a common interface for interacting with the reference database, introducing a dedicated Refdb type rather than exposing refdb operations solely as convenience methods on Repository
  • Add 1 additional feature set_refdb() as an example of how this new interface make extending it easier

1 change:

  • Renamed Refdb to RefdbMarker to avoid confusion with the new public Refdb type in refdb.rs; this is just a lifetime marker, not a user-facing type

…, and delegate Repository::refdb_compress() to it
@rustbot rustbot added the S-waiting-on-review Status: Waiting on review label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Waiting on review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants