Skip to content

github-updater: recognize HTTP 429 as RateLimitReached #3195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syphar merged 1 commit into from
Feb 9, 2026
Merged

github-updater: recognize HTTP 429 as RateLimitReached #3195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion crates/lib/docs_rs_repository_stats/src/github.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ impl GitHub {
let status = response.status();
let body = response.text().await?;

if status == StatusCode::FORBIDDEN
if status == StatusCode::TOO_MANY_REQUESTS {
Err(RateLimitReached.into())
} else if status == StatusCode::FORBIDDEN
&& let Ok(api_error) = serde_json::from_str::<ApiError>(&body)
&& (api_error
.documentation_url
Expand Down Expand Up @@ -473,4 +475,28 @@ mod tests {

Ok(())
}

#[tokio::test]
async fn test_429_rate_limit() -> Result<()> {
let config = github_config()?;
let (mut server, updater) = mock_server_and_github(&config).await;

let _m1 = server
.mock("POST", "/graphql")
.with_header("content-type", "application/json")
.with_status(429)
.create();

assert!(
updater
.fetch_repository(
&repository_name("https://gitlab.com/foo/bar").expect("repository_name failed"),
)
.await
.unwrap_err()
.is::<RateLimitReached>()
);

Ok(())
}
}
Loading