Don't keep old failed builds in the build queue#3178
Merged
GuillaumeGomez merged 1 commit intorust-lang:mainfrom Feb 5, 2026
Merged
Don't keep old failed builds in the build queue#3178GuillaumeGomez merged 1 commit intorust-lang:mainfrom
GuillaumeGomez merged 1 commit intorust-lang:mainfrom
Conversation
0ac9057 to
6b51d4c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
6b51d4c to
c788658
Compare
Member
Author
|
@GuillaumeGomez ready for review now |
GuillaumeGomez
approved these changes
Feb 5, 2026
Member
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have two main kinds of build-errors:
Since we also add in-progress builds to the database, we can see both error types in the proper interfaces.
But (My guess) from the times before that, we wanted some record of the failed build. And these were these queue entries where we tried more than X times.
This leads to around ~5k entries in the queue table of old failed builds.
I don't think we need these any more and can keep a clean queue table without any issues.
I also fixed my
TestMetrics/CollectedMetricstesting stub, which returned the wrong values when we queried the values multiple times.