Skip to content

Fix hardened derivation path error handling in at_derivation_index #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Velnbur wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix hardened derivation path error handling in at_derivation_index #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/descriptor/key.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -906,6 +906,7 @@ impl DescriptorPublicKey {
/// # Errors
///
/// - If `index` is hardened.
/// - If derivation path contains a hardened step.
/// - If the key contains multi-path derivations
pub fn at_derivation_index(
self,
Expand Down Expand Up @@ -937,8 +938,7 @@ impl DescriptorPublicKey {
DescriptorPublicKey::MultiXPub(_) => return Err(NonDefiniteKeyError::Multipath),
};

Ok(DefiniteDescriptorKey::new(definite)
.expect("The key should not contain any wildcards at this point"))
DefiniteDescriptorKey::new(definite)
}

/// Whether or not this key has multiple derivation paths.
Expand Down
Loading