plan: remove unused AssetProvider::provider_lookup_tap_control_block_map#826
Merged
apoelstra merged 1 commit intorust-bitcoin:masterfrom Jun 6, 2025
Merged
plan: remove unused AssetProvider::provider_lookup_tap_control_block_map#826apoelstra merged 1 commit intorust-bitcoin:masterfrom
apoelstra merged 1 commit intorust-bitcoin:masterfrom
Conversation
Member
|
Heh, yeah, strange. This method dates to the original plan PR and AFAICT was never used. #592 This functionality also doesn't seem to make sense coming from the asset provider (we have methods on |
heap-coder
added a commit
to heap-coder/rust-miniscript
that referenced
this pull request
Sep 27, 2025
…ider::provider_lookup_tap_control_block_map
42052941e3c43494df97e7d8d195c078a550131b plan: remove unused AssetProvider::provider_lookup_tap_control_block_map (Marko Bencun)
Pull request description:
Was not sure if/when/how to implement it, when I noticed it's not needed at all.
ACKs for top commit:
apoelstra:
ACK 42052941e3c43494df97e7d8d195c078a550131b; successfully ran local tests
Tree-SHA512: d0067ef38b5ad84a3d5ef66a437e60c1f6bec17c937ad758789308b981be8f0a20467f9288a8693acbd62893580989233cb85ba005ca57b8fcb59064edd598c6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was not sure if/when/how to implement it, when I noticed it's not needed at all.