Fix duplicate rustsec issue creation#652
Open
jamillambert wants to merge 1 commit into
Open
Conversation
satsfy
approved these changes
Jul 2, 2026
Contributor
There was a problem hiding this comment.
tACK e5889c8
I tested by running on my fork. It indeed ran jobs in sequence, which were previously run in parallel. The most important part, about issue duplication, can be attested to here in this CI log run because the log catches issue duplication emitting log Seems like RUSTSEC-2026-0190 is mentioned already in the issues/PRs, will not report an issue against it. Two issues were properly created (not duplicates) and no more.
I have just one optional nit.
| fail-fast: false | ||
| # rustsec/audit-check skips advisories that are already mentioned in an | ||
| # open issue, but when jobs run concurrently duplicate issues are created. | ||
| # Run one at a time so that issues created are seen by the next jobs. |
Contributor
There was a problem hiding this comment.
nit: seems verbose, why not "Run one at a time, otherwise parallel jobs create the same advisory issue twice."?
Collaborator
Author
There was a problem hiding this comment.
Yeah that is better. I changed it.
When the audit runs on all 3 lockfiles at the same time a problem in multiple lockfiles can result in multiple issues being created for the same RustSec ID. Run the jobs one at a time so that issues created are seen by the next jobs and no duplicate issue is created.
jamillambert
force-pushed
the
0630-duplicate-rustsec-issues
branch
from
e5889c8 to
2fecab1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the audit runs on all 3 lockfiles at the same time a problem in multiple lockfiles can result in multiple issues being created for the same RustSec ID.
Run the jobs one at a time so that issues created are seen by the next jobs and no duplicate issue is created.