Skip to content

Fix UI entry bugs and enhance netherworld challenge features#1635

Open
leovefy wants to merge 9 commits into
runhey:devfrom
leovefy:cobra
Open

Fix UI entry bugs and enhance netherworld challenge features#1635
leovefy wants to merge 9 commits into
runhey:devfrom
leovefy:cobra

Conversation

@leovefy

@leovefy leovefy commented Jun 23, 2026

Copy link
Copy Markdown

Summary by Sourcery

改进逢魔之时 Boss 阶段的预设切换流程、部分活动页面的 UI 识别稳定性,以及服务端 JSON 响应编码;同时新增“茨心乐园”庭院皮肤适配。

New Features:

  • 支持在逢魔之时集结阶段切换 Boss 预设,可使用配置中的预设分组与队伍。
  • 新增 ASCII-only JSON 响应类型,并将 FastAPI 默认响应类切换为该类型,以提升部分代理环境下的兼容性。
  • 新增 COSTUME_MAIN_15(茨心乐园)庭院皮肤资源与庭院入口导航适配。

Bug Fixes:

  • 分离记录逢魔之时集结阶段与准备阶段的预设切换尝试,避免准备过程中重复执行预设切换。
  • 在重新点击入口前增加导航 UI 识别,使进行中的 Abyss Shadows 战斗可以稳定重新进入。
  • 扩大六道之门、Abyss Shadows、冥界挑战和逢魔之时退治状态相关识别 ROI,提高页面判断稳定性。
  • 修正英杰试炼 Art War Plus 卡牌 OCR 的模式与数值处理,避免 OCR 结果类型导致比较异常或误解析。
  • 修正部分探索/检查图像的 ROI,避免六道之门场景被错误识别。

Enhancements:

  • 通用战斗预设切换流程现在可以复用已打开的预设面板,减少不必要的 UI 操作。
  • 补充逢魔之时 Boss 预设切换所需的专用点击点、识别图和配置面板资源。
  • 扩展庭院皮肤基础映射范围,支持新的 main15 庭院资源。

Documentation:

  • 新增 AGENT.md,提供单任务问题定位、修复和验证的推荐工作流。

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - 我在这里给了一些高层次的反馈:

  • HeroTest.script_task.check_art_war_card 中,你在把 O_ART_WAR_CARD_PLUS 改成 Digit 模式时移除了对 cu 的显式 int 转换;请确认 ocr() 现在可以稳定返回整数(而不是字符串),或者重新加上安全的类型转换,以避免在执行 cu >= 1 时出现类型比较问题。
给 AI Agent 的提示
Please address the comments from this code review:

## Overall Comments
- In `HeroTest.script_task.check_art_war_card`, you removed the explicit `int` conversion for `cu` while changing `O_ART_WAR_CARD_PLUS` to `Digit` mode; please confirm `ocr()` now reliably returns an integer (not a string) or reintroduce a safe cast to avoid type comparison issues when doing `cu >= 1`.

Sourcery 对开源项目免费——如果你觉得我们的 Review 有帮助,欢迎分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈来改进 Review 质量。
Original comment in English

Hey - I've left some high level feedback:

  • In HeroTest.script_task.check_art_war_card, you removed the explicit int conversion for cu while changing O_ART_WAR_CARD_PLUS to Digit mode; please confirm ocr() now reliably returns an integer (not a string) or reintroduce a safe cast to avoid type comparison issues when doing cu >= 1.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- In `HeroTest.script_task.check_art_war_card`, you removed the explicit `int` conversion for `cu` while changing `O_ART_WAR_CARD_PLUS` to `Digit` mode; please confirm `ocr()` now reliably returns an integer (not a string) or reintroduce a safe cast to avoid type comparison issues when doing `cu >= 1`.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@runhey

runhey commented Jun 24, 2026

Copy link
Copy Markdown
Owner

不得行哦,你让agent把这个pr拆分一下,我太困了,明天有空再看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants