Skip to content

Add pvm-tools#14191

Open
arbeerby-pixel wants to merge 3 commits into
runelite:masterfrom
arbeerby-pixel:codex/add-pvm-tools
Open

Add pvm-tools#14191
arbeerby-pixel wants to merge 3 commits into
runelite:masterfrom
arbeerby-pixel:codex/add-pvm-tools

Conversation

@arbeerby-pixel

@arbeerby-pixel arbeerby-pixel commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds PvM Tools, a RuneLite combat companion with potion and prayer timers, configurable warnings, valuable-drop reminders, configurable Loot Glow, cannon alerts, Slayer task history, persistent loot/supply/XP statistics, and coordinated chat-tab trackers.

Behavior

  • Loot Glow outlines only drops visible through RuneLite's Ground Items settings and supports configurable color and width.
  • Update notes use a bounded, non-modal panel attached to the RuneLite layered pane, so gameplay outside the panel remains clickable.
  • Plugin shutdown removes overlays, infoboxes, navigation, update UI, and restores modified chat-tab widgets.
  • Tracker defaults are initialized once and are not forced again after users change them.
  • No reflection or third-party runtime dependencies are used by the plugin.

Validation

  • gradlew.bat test --no-daemon passes on Java 21 targeting Java 11.
  • Tests cover config defaults, Loot Glow defaults, update-panel close/disable behavior and bounds, Slayer task history persistence/merging, tracker resets, and statistics serialization.
  • Root Plugin Hub icon is 48x72 with transparency.

@runelite-github-app

runelite-github-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jul 22, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@arbeerby-pixel

Copy link
Copy Markdown
Contributor Author

Hi, just a gentle reminder when a maintainer has time to review this new plugin submission. The Plugin Hub build is passing and there are currently no requested changes. Thank you!

@coopermor

Copy link
Copy Markdown
Contributor

Reviewers work on a volunteer basis and will get to your plugin when they have time to review it. It is not forgotten about.

@arbeerby-pixel

Copy link
Copy Markdown
Contributor Author

Additional context for the review: the old PvM Toolkit plugin has been fully discontinued and removed. PvM Tools is a fresh rewrite rather than a simple rename or restoration of the previous plugin.

The scope was deliberately reduced, several problematic or unnecessary features were left out, and the remaining features were rebuilt with simpler lifecycle and state handling. We have tested the submitted version through repeated developer-client launches and normal gameplay sessions, including plugin enable/disable, logout/login, timers, trackers, cannon alerts, drops, and the side panel. The Plugin Hub build also passes, and we have not found any known blocking issues in the submitted build.

I hope this helps clarify that this PR should be reviewed as a new, cleaner implementation rather than the previously removed plugin. Thank you for taking the time to review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants