Update 07flip to eca1b23#12121
Merged
runelite-github-app[bot] merged 1 commit intoMay 22, 2026
Merged
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
25fbc1a
into
runelite:master
2 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug-fix release for the My Trades panel.
A user reported that completed flips were showing inflated profit numbers (e.g. a flip with a real ~350K profit was displaying as +1.74M). The plugin was treating gross sell totals as net, so every closed flip was overstated by roughly the GE tax. This release subtracts the 2% GE tax from sells before computing profit, which corrects:
Also includes a small improvement that uses the trade_id field the 07flip server now returns on POST responses, so locally-recorded trades can be reconciled with the server immediately instead of waiting for the next history sync.
No new dependencies, no config changes, no new permissions.