Skip to content

Update 07flip to 8917dbb#11875

Merged
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
UserD40:update-07flip-1778532824
May 17, 2026
Merged

Update 07flip to 8917dbb#11875
runelite-github-app[bot] merged 5 commits into
runelite:masterfrom
UserD40:update-07flip-1778532824

Conversation

@UserD40
Copy link
Copy Markdown
Contributor

@UserD40 UserD40 commented May 11, 2026

Update 07flip plugin to commit 8917dbb. Major UX overhaul: Item insights tab, My Trades redesign with progress-bar rows, guided GE buy/sell auto-fill flows, GE overlay with cached insights + 24h chart, incremental partial-fill recording with merge-by-offerInstanceId, GE tax accounting in profit calculations, and premium gating for rec prices + frozen-sell feature.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 11, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented May 11, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Copy Markdown
Contributor

log.info -> log.debug

@LlemonDuck LlemonDuck added the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 12, 2026
@UserD40
Copy link
Copy Markdown
Contributor Author

UserD40 commented May 12, 2026

Thanks for the review! Demoted every log.info to log.debug across the plugin source — pushed in 3a449cf.

@UserD40
Copy link
Copy Markdown
Contributor Author

UserD40 commented May 14, 2026

Updated to 43c634f. My Trades correctness pass:

  • Three dedup passes in TradeHistoryDedup for the duplicate-trade-row patterns that were inflating Today/Worst figures (server-fill subsumption, stale-partial twins, stuck-observation re-records).
  • healBackdatedTimestamps rewrites buy timestamps that the old back-dating heuristic pushed before unrelated trades, restoring FIFO order.
  • Bonds moved to a lifetime BondLedger persisted outside the 200-row trade window so Membership cost survives heavy flipping. One-shot migration seeds from existing bond rows; manual Adjust lifetime dialog covers history evicted before the ledger existed.
  • New Filter pill on My Trades (Daily/Weekly/Monthly/All time) scopes stats and list rows; Recent gets a Profit/ROI/Quantity sort; Margin sort moves under the stats card.
  • Frozen sell prices now timestamped; refresh against current 07flip rec_sell after configurable staleness threshold (default 3h). Cache pre-warms on buy fills so the GE setup auto-fill arms instantly.
  • Server-side post path simplified: one terminal-state row per offer instead of per-fill deltas (eliminates the sync echo that caused the original duplication).
  • Test count: 42 (up from 23).

@UserD40
Copy link
Copy Markdown
Contributor Author

UserD40 commented May 14, 2026

Updated to c2689aa. Shortens the My Trades period filter labels (Today / Week / Month / All) so the Margin sub-tab stays on the visible header row. Empty-state copy and tooltips use a longer-form phrase helper so prose still reads naturally.

@Adam- Adam- added waiting for author waiting for the pr author to make changes or respond to questions and removed waiting for author waiting for the pr author to make changes or respond to questions labels May 17, 2026
@runelite-github-app runelite-github-app Bot merged commit e998e9a into runelite:master May 17, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants