Skip to content

Add Rune Vault plugin#11424

Open
EhhForge wants to merge 21 commits into
runelite:masterfrom
EhhForge:EhhForge-patch-1
Open

Add Rune Vault plugin#11424
EhhForge wants to merge 21 commits into
runelite:masterfrom
EhhForge:EhhForge-patch-1

Conversation

@EhhForge
Copy link
Copy Markdown

@EhhForge EhhForge commented Apr 8, 2026

Rune Vault is a portfolio tracker for OSRS. The plugin syncs bank contents, GE trades, and item pickups/drops to the Rune Vault app in real time. Auth is via a 6-character link code generated in the app. All data is sent over HTTPS to our own Supabase backend.

Note: the app is currently in pre-launch and not yet on the App Store or Google Play. Happy to provide early access to the team for testing.

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 8, 2026

@cdfisher
Copy link
Copy Markdown
Contributor

cdfisher commented Apr 8, 2026

Your repo needs to be public

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app Bot commented Apr 8, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

EhhForge and others added 8 commits April 8, 2026 22:48
Plugin-side rotation from legacy anon JWT to sb_publishable_*.
No behavioral change; smaller key, RLS continues to enforce access.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Drops a build.gradle config (failOnNoDiscoveredTests) that was
unsupported on this CI's Gradle 8.10.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds build=standard to runelite-plugin.properties so plugin-hub's
packager knows to use its bundled core deps.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@riktenx riktenx closed this May 16, 2026
@riktenx riktenx reopened this May 16, 2026
@riktenx
Copy link
Copy Markdown
Member

riktenx commented May 16, 2026

  • use of Thread sleep is not allowed
  • use of Thread interrupt is not allowed

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label May 16, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 20, 2026
@EhhForge EhhForge requested a review from a team as a code owner May 20, 2026 20:15
@EhhForge
Copy link
Copy Markdown
Author

Thanks for the review @riktenx , both addressed.

Thread.sleep and Thread.currentThread().interrupt() have been removed from src/main (verified: 0 occurrences of each). All retry backoff now goes through a daemon ScheduledExecutorService (retryScheduler.schedule(...)), which means the runtime no longer parks a thread on failure and no interrupt restoration is needed.

Fix: [370ad41] [https://github.com/EhhForge/RuneVault-on-RuneLite/commit/370ad41]

Plugin-hub commit= bumped to 28b954a465a75c617452ffcc90bb4a6f6bb50ae9.
Ready for another look.

@ldavid432
Copy link
Copy Markdown
Contributor

You should not be adding an icon in this repository. An icon.png can be placed at the root of your plugin's repository

See step 10 on https://github.com/runelite/plugin-hub/blob/master/README.md#creating-new-plugins

@ldavid432 ldavid432 added the waiting for author waiting for the pr author to make changes or respond to questions label May 21, 2026
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label May 22, 2026
@EhhForge
Copy link
Copy Markdown
Author

Thanks @ldavid432 , this has been addressed.
The icon.png has been moved to the root of the plugin repo.
The icons/ directory has been removed from this PR, so it now only touches plugins/rune-vault.
Plugin-hub commit= bumped to 4bc5d547fdb986c298beff1c07649ad388d384d8. Ready for another look.

Fixes a 6-week-old silent regression where every plugin upsert returned
PostgREST 42P10 (on_conflict columns stopped matching after a 4-col
constraint replaced the old 5-col one). Bank scans and cash updates
hadn't been persisting to the DB.
Comment thread plugins/rune-vault Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants