Merged
Conversation
- Renamed ChanceMan to Choicer - Moved account/ drops/ filters/ managers/ to com.choicer -- refactored account/ drops/ filters/ managers/ to use com.choicer - Moved overlay / plugin / panel / config / etc to com.choicer -- refactored overlay / plugin / panel / config / etc to use com.choicer - Renamed Choiceman to Choicer -- refactored Choiceman to Choicer - Refactored hitbox detection to use simple rectangles instead of rounded rectangles
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Member
|
something is extremely wrong here, format your code in this file. it is impossible to read. you can press ctrl+alt+L in IntelliJ with the file open. 
|
riktenx
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note, this was purely moving the files and refactoring classess and methods accordingly. Now "ChanceMan" and "ChoiceMan" are totally gone.
The only actual modifications, were in ChoicerOverlay.java for tests to run