Add auto-entity-hider

[P2GR]

Automatically enable a custom entity hider configuration when you enter certain regions/locations e.g. ToA boss rooms, GotR, GE

[runelite-github-app]

New plugin auto-entity-hider: https://github.com/P2GR/auto-entity-hider/tree/9365b4f62f7c64fe616bf5d48fb35ab385ef11be

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[geheur]

modifying other plugins' config has caused issues in the past due to the many ways that configs can be changed, and with entity hider being such an impactful plugin, having it on at the wrong time due to a bug would suck. Have you considered copypasting entity hider and adding some region logic, and then making it exclusive with entity hider (in plugindescriptor conflicts field)?

[P2GR]

modifying other plugins' config has caused issues in the past due to the many ways that configs can be changed, and with entity hider being such an impactful plugin, having it on at the wrong time due to a bug would suck. Have you considered copypasting entity hider and adding some region logic, and then making it exclusive with entity hider (in plugindescriptor conflicts field)?

Yeah can do that. the idea came from the plugin: Automatic Low Detail, which enables the Low Detail plugin in the same way.
That's why i thought it wouldn't really pose an issue.

What would you prefer?
Copy pasting entity hider and adding the region logic?

maybe adding a game chat message saying [Auto Entity Hider] Entered region: Grand Exchange would already suffice to make it clear to people what's going on?

[geheur]

having the wrong entity hider settings is a much bigger deal than low detail, I wouldn't risk it, and copypasting entity hider is not too difficult. Please do it that way instead. Chat message does not help, the concern is that the plugin might not restore settings when it should.

[P2GR]

@geheur

updated the plugin and it now uses the native entity hider as utility class.
if you still have feedback, please let me know!

[geheur]

Looks ok to me but isn't this functionally different from before? It sets all fields to false when leaving a region but before it would use the entity hider plugin's config? Not a problem for accepting the plugin but idk if that's what you intended.

You could read the existing entity hider config for when you're outside of one of these regions. Or you could have a second set of config settings.