Update modern-chat - Features

[BenDol]

Features

It would be nice to address this (or another suggestion) runelite/runelite#19861 to resolve KeyRemappingPlugin conflicts. I've solved it by duplicating the KeyRemappingPlugin functionality which I'd prefer to not do.

---

New Tabs:

• Dedicated Game tab for game/system messages (can be disabled in the settings)
• Dedicated Trade tab for trade messages (can be disabled in the settings)

Channel Filters:

• Filter button on input box to toggle message types
• Filter by: Public, Private, Clan, Friends Chat, Trade, Game, System, Auto Typed

Spam Integration:

• Will properly account for spam filtering
• Right-click messages to mark spam/ham
• Shares corpus files with SpamFilterPlugin

ChatFilterPlugin Support:

• Respects message blocking and collapse settings
• Duplicate message collapse detection

Other:

• Add missing Friends Chat kick option (if permitted)
• Set peek source tab via tab right-click menu
• Per-tab notification muting via tab right-click menu
• Suppress peek fade at GE option (Stops the peek overlay from auto-fading in on messages while at the Grand Exchange)
• Add extended toggle key binding support (Mouse Button 4/5 & F13-24 support)
• Add custom Timestamp Color & Type Prefix Color configurations
• Add ForceRecolorPlugin integration
• Make sure the peek overlay supports message collapsing
• Add peek source border highlight to the tab
• Add optional report button + session timer (similar to the legacy version)
• Add tab icon support (optional)
• (Remove classic mode) This ends up being redundant with the new filtering features, auto close pm tab config and tab muting
• Add a separate "Show NPC Messages" setting for peek overlay and make sure they suppress rendering rather than adding

---

---

Chat Type Filtering

---

Set Peek Source & Mute notifications

---

Tab Icons

---

[runelite-github-app]

modern-chat: 263760b6a36e7bf1f93656eb40c6a711b727b696..5cc971f81951ed5c33ed8d06d2d91d04f6849433

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[BenDol]

Ready for review when ever possible, shouldn't be any updates other than bug fixes to the features if I find any later.

[LlemonDuck]

you should not submit arbitrary, manual KeyEvents to the canvas, it may trip anticheat measures.

you mentioned a conflict with core KeyRemapping, but that plugin doesn't do this either, it modifies the existing KeyEvent and just switches the keycode. what issue are you trying to solve?

[BenDol]

you should not submit arbitrary, manual KeyEvents to the canvas, it may trip anticheat measures.

you mentioned a conflict with core KeyRemapping, but that plugin doesn't do this either, it modifies the existing KeyEvent and just switches the keycode. what issue are you trying to solve?

Which part of the code are you referring to here? Sorry been a while since I worked on this. This is the issue with the key remapping plugin conflicts: runelite/runelite#19861 (the PR explains it and gives my ideal solution where I wouldn't need to recreate the key remapper plugin like I've done here).

Edit: If you're referring to the ExtendedKeybind feature that is a separate feature not related to the KeyRemapping issues and to be honest I can remove it if it's not viable to send key events.

[LlemonDuck]

If you're referring to the ExtendedKeybind feature that is a separate feature

yes i'm referring to that

[BenDol]

If you're referring to the ExtendedKeybind feature that is a separate feature

yes i'm referring to that

Okay I've removed this feature for now

[LlemonDuck]

you cannot create menu actions that will invoke send to server, even if mundane and well intended. everything else looks good (can't recommend using ahk to test your plugin tho). if you remove these two i can merge

https://github.com/BenDol/Modern-Chat/compare/263760b6a36e7bf1f93656eb40c6a711b727b696..BenDol:031396889c1b9f90bceb51c90c07b2dbbdad645e#diff-a9d0aa085026cd103a178537517e3de72ec7037f6f9bf67dd7e8c5481d81dfb4R892-R898

https://github.com/BenDol/Modern-Chat/compare/263760b6a36e7bf1f93656eb40c6a711b727b696..BenDol:031396889c1b9f90bceb51c90c07b2dbbdad645e#diff-a9d0aa085026cd103a178537517e3de72ec7037f6f9bf67dd7e8c5481d81dfb4R1525-R1531

[BenDol]

you cannot create menu actions that will invoke send to server, even if mundane and well intended. everything else looks good (can't recommend using ahk to test your plugin tho). if you remove these two i can merge

https://github.com/BenDol/Modern-Chat/compare/263760b6a36e7bf1f93656eb40c6a711b727b696..BenDol:031396889c1b9f90bceb51c90c07b2dbbdad645e#diff-a9d0aa085026cd103a178537517e3de72ec7037f6f9bf67dd7e8c5481d81dfb4R892-R898

https://github.com/BenDol/Modern-Chat/compare/263760b6a36e7bf1f93656eb40c6a711b727b696..BenDol:031396889c1b9f90bceb51c90c07b2dbbdad645e#diff-a9d0aa085026cd103a178537517e3de72ec7037f6f9bf67dd7e8c5481d81dfb4R1525-R1531

Removed. Really appreciate you taking the time to review, thanks!