forked from ohioit/rundeck-http-plugin
-
Notifications
You must be signed in to change notification settings - Fork 15
Grails 7 Migration - Rundeck 6.0 Compatibility #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
982f0c4
Update for Grails 7 compatibility
fdevans 64b5297
Update GitHub workflow to use Java 17 for Grails 7 compatibility
fdevans f2b9915
Update rundeck-core dependency to 6.0.0-SNAPSHOT for Grails 7 compati…
fdevans 1486f38
Add Central Portal Snapshots repository for rundeck-core:6.0.0-SNAPSHOT
fdevans f332ca6
Prepare http-step for JitPack with Java 17 and Central Portal Snapshots
fdevans ffb0cfe
Add Central Portal Snapshots repository for rundeck-core:6.0.0-SNAPSH…
fdevans 65669cb
Bump version to 1.1.11-grails7-upgrade-test
fdevans 5b91557
Fix jitpack.yml to use Java 17 instead of Java 11
fdevans b5feebc
Bump version to 1.1.12-grails7-upgrade-test
fdevans a3be07b
Fix commons-lang3 version conflict
fdevans 95365bb
Standardize on commons-lang3:3.18.0
fdevans 2708fd3
Downgrade commons-lang3 to 3.17.0 for Grails 7 compatibility
fdevans fbc5801
Bump version to 1.1.16 due to JitPack build timeout
fdevans cad5419
Bump version to 1.1.17-grails7-upgrade-test
fdevans bfbf9b7
Modernize build.gradle and bump to 1.1.18-grails7-upgrade-test
fdevans e8f6ba0
Migrate to PackageCloud: restore Axion, change groupId to com.rundeck…
fdevans 069f623
Merge remote-tracking branch 'origin/master' into grails7-upgrade
fdevans 1a0d7f2
Fix CVE-2025-48924: Update commons-lang3 to 3.18.0
fdevans a6482ed
Modernize CI workflows for Java 17 and Node.js 24
fdevans 2d02ec3
Modernize GitHub Actions workflows for Node.js 24 compatibility
fdevans 46ab011
Standardize Gradle version to 8.14.3
fdevans 1b88fdd
Fix YAML indentation for distribution parameter
fdevans 5b7f8bf
Update Gradle wrapper scripts to 8.14.3
fdevans 81a56c0
Fix distribution parameter indentation in workflows
fdevans 6d9d77b
Update commons-lang3 to 3.20.0 to match rundeck core
fdevans 34cc393
Add Maven Publishing
fdevans 7d041f4
Update build.gradle
fdevans File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,46 +1,42 @@ | ||
| on: | ||
| push: | ||
| # Sequence of patterns matched against refs/tags | ||
| tags: | ||
| - '*' # Push events to matching v*, i.e. v1.0, v20.15.10 | ||
| - '*.*.*' | ||
|
|
||
| name: Upload Release Asset | ||
| name: Publish Release | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Upload Release Asset | ||
| name: Publish Release | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v2 | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: set up JDK 1.8 | ||
| uses: actions/setup-java@v1 | ||
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| java-version: 11 | ||
| java-version: '17' | ||
| distribution: 'zulu' | ||
| - name: Build with Gradle | ||
| run: ./gradlew build | ||
| - name: Get Release Version | ||
| id: get_version | ||
| run: VERSION=$(./gradlew currentVersion -q -Prelease.quiet) && echo ::set-output name=VERSION::$VERSION | ||
| run: VERSION=$(./gradlew currentVersion -q -Prelease.quiet) && echo "VERSION=$VERSION" >> $GITHUB_OUTPUT | ||
| - name: Create Release | ||
| id: create_release | ||
| uses: actions/create-release@v1.0.0 | ||
| run: | | ||
| gh release create \ | ||
| --generate-notes \ | ||
| --title 'Release ${{ steps.get_version.outputs.VERSION }}' \ | ||
| ${{ github.ref_name }} \ | ||
| build/libs/http-step-${{ steps.get_version.outputs.VERSION }}.jar | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| tag_name: ${{ github.ref }} | ||
| release_name: Release ${{ steps.get_version.outputs.VERSION }} | ||
| draft: false | ||
| prerelease: false | ||
| - name: Upload Release Asset (jar) | ||
| id: upload-release-asset | ||
| uses: actions/upload-release-asset@v1 | ||
| - name: Publish to Maven Central | ||
| run: ./gradlew -PsigningKey=${SIGNING_KEY_B64} -PsigningPassword=${SIGNING_PASSWORD} -PsonatypeUsername=${SONATYPE_USERNAME} -PsonatypePassword=${SONATYPE_PASSWORD} publishToSonatype closeAndReleaseSonatypeStagingRepository | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| upload_url: ${{ steps.create_release.outputs.upload_url }} | ||
| asset_path: build/libs/http-step-${{ steps.get_version.outputs.VERSION }}.jar | ||
| asset_name: http-step-${{ steps.get_version.outputs.VERSION }}.jar | ||
| asset_content_type: application/octet-stream | ||
| SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | ||
| SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
| SIGNING_KEY_B64: ${{ secrets.SIGNING_KEY_B64 }} | ||
| SIGNING_PASSWORD: ${{ secrets.SIGNING_PASSWORD }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| /** | ||
| * Define project extension values in the project gradle file before including this file: | ||
| * | ||
| * publishName = 'Name of Package' | ||
| * publishDescription = 'description' (optional) | ||
| * githubSlug = Github slug e.g. 'rundeck/rundeck-cli' | ||
| * developers = [ [id:'id', name:'name', email: 'email' ] ] list of developers | ||
| * | ||
| * Define project properties to sign and publish when invoking publish task: | ||
| * | ||
| * ./gradlew \ | ||
| * -PsigningKey="base64 encoded gpg key" \ | ||
| * -PsigningPassword="password for key" \ | ||
| * -PsonatypeUsername="sonatype token user" \ | ||
| * -PsonatypePassword="sonatype token password" \ | ||
| * publishToSonatype closeAndReleaseSonatypeStagingRepository | ||
| */ | ||
| apply plugin: 'maven-publish' | ||
| apply plugin: 'signing' | ||
|
|
||
| publishing { | ||
| publications { | ||
| "${project.name}"(MavenPublication) { publication -> | ||
| from components.java | ||
|
|
||
| pom { | ||
| name = publishName | ||
| description = project.ext.hasProperty('publishDescription') ? project.ext.publishDescription : | ||
| project.description ?: publishName | ||
| url = "https://github.com/${githubSlug}" | ||
| licenses { | ||
| license { | ||
| name = 'The Apache Software License, Version 2.0' | ||
| url = 'http://www.apache.org/licenses/LICENSE-2.0.txt' | ||
| distribution = 'repo' | ||
| } | ||
| } | ||
| scm { | ||
| url = "https://github.com/${githubSlug}" | ||
| connection = "scm:git:git@github.com/${githubSlug}.git" | ||
| developerConnection = "scm:git:git@github.com:${githubSlug}.git" | ||
| } | ||
| if (project.ext.developers) { | ||
| developers { | ||
| project.ext.developers.each { dev -> | ||
| developer { | ||
| id = dev.id | ||
| name = dev.name | ||
| email = dev.email | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| } | ||
| } | ||
| repositories { | ||
| def pkgcldWriteToken = System.getenv("PKGCLD_WRITE_TOKEN") ?: project.findProperty("pkgcldWriteToken") | ||
| if (pkgcldWriteToken) { | ||
| maven { | ||
| name = "PackageCloudTest" | ||
| url = uri("https://packagecloud.io/pagerduty/rundeckpro-test/maven2") | ||
| authentication { | ||
| header(HttpHeaderAuthentication) | ||
| } | ||
| credentials(HttpHeaderCredentials) { | ||
| name = "Authorization" | ||
| value = "Bearer " + pkgcldWriteToken | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| def base64Decode = { String prop -> | ||
| project.findProperty(prop) ? | ||
| new String(Base64.getDecoder().decode(project.findProperty(prop).toString())).trim() : | ||
| null | ||
| } | ||
|
|
||
| if (project.hasProperty('signingKey') && project.hasProperty('signingPassword')) { | ||
| signing { | ||
| useInMemoryPgpKeys(base64Decode("signingKey"), project.signingPassword) | ||
| sign(publishing.publications) | ||
| } | ||
| } |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider pinning the wrapper distribution with
distributionSha256Sumfor supply-chain integrity. Right now the wrapper will downloadgradle-8.14.3-bin.zipwithout checksum verification, which weakens defenses against tampering.