build(deps): bump cpal from 0.16.0 to 0.17.1#22693
Open
dependabot[bot] wants to merge 2 commits intomasterfrom
Open
build(deps): bump cpal from 0.16.0 to 0.17.1#22693dependabot[bot] wants to merge 2 commits intomasterfrom
dependabot[bot] wants to merge 2 commits intomasterfrom
Conversation
dependabot
Bot
added
A-deps
dependabot
Bot
force-pushed
the
dependabot/cargo/cpal-0.17.1
branch
4 times, most recently
from
75b0033 to
13f35a9
Compare
Bumps [cpal](https://github.com/RustAudio/cpal) from 0.16.0 to 0.17.1. - [Release notes](https://github.com/RustAudio/cpal/releases) - [Changelog](https://github.com/RustAudio/cpal/blob/master/CHANGELOG.md) - [Commits](RustAudio/cpal@v0.16.0...v0.17.1) --- updated-dependencies: - dependency-name: cpal dependency-version: 0.17.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/cpal-0.17.1
branch
from
13f35a9 to
3884aca
Compare
SuchAFuriousDeath
suggested changes
Jan 22, 2026
| if let Ok(devices) = audio_host.output_devices() { | ||
| for device in devices { | ||
| if let Ok(name) = device.name() { | ||
| if let Ok(name) = device.description().map(|d| d.name().to_owned()) { |
Collaborator
There was a problem hiding this comment.
Is calling .to_owned() really necessary here?
| && let Some(device) = | ||
| devices.find(|device| device.name().ok().as_deref() == Some(preferred_device_name)) | ||
| && let Some(device) = devices.find(|device| { | ||
| device.description().ok().map(|d| d.name().to_owned()) |
Collaborator
There was a problem hiding this comment.
Same question here.
| devices.find(|device| device.name().ok().as_deref() == Some(preferred_device_name)) | ||
| && let Some(device) = devices.find(|device| { | ||
| device.description().ok().map(|d| d.name().to_owned()) | ||
| == Some(preferred_device_name.to_owned()) |
Member
|
I think they are, because of some lifetime things... But anyway, I think some things need revising, as on Linux, I see so many devices with identical names now... |
Contributor
Author
|
A newer version of cpal exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps cpal from 0.16.0 to 0.17.1.
Release notes
Sourced from cpal's releases.
... (truncated)
Changelog
Sourced from cpal's changelog.
... (truncated)
Commits
ddad8bcchore: prepare cpal v0.17.1 and asio-sys v0.2.5 release (#1090)17a2abdfix(asio-sys): case-insensitive ASIO SDK discovery (#1082)38e3b09fix(wasm): wasm-bindgen break (#1086)7ec4e88ci: check default/no-default/all feature sets with platform-dependent MSRV fo...c6e2461Fix AudioWorklet example (#1088)1162be5chore(jack): bump MSRV to 1.82271a17adocs: fix Discord invite linkseb213b4refactor(alsa): handle more open errorse845974fix(alsa): avoid poisoning during enumerationfe9ef97fix(alsa): treat NULL ALSA IOID as DuplexYou can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)