avm1: Stub `flash.automation.*` classes by kjarosh · Pull Request #22517 · ruffle-rs/ruffle

kjarosh · 2025-12-14T20:23:37Z

This patch stubs:

flash.automation.Configuration,
flash.automation.ActionGenerator,
flash.automation.StageCapture.

moulins · 2025-12-16T16:22:49Z

The playerglobals.swf shows the attributes as being:

DONT_ENUM, DONT_DELETE for StageCapture;
DONT_ENUM, DONT_DELETE, READ_ONLY for ActionGenerator and Configuration.

Is the discrepancy intentional?

kjarosh · 2025-12-16T16:49:16Z

Hmmm, I thought the attributes were already tested; I'll take a look later

kjarosh · 2025-12-21T21:23:44Z

The playerglobals.swf shows the attributes as being:
* `DONT_ENUM, DONT_DELETE` for `StageCapture`;

* `DONT_ENUM, DONT_DELETE, READ_ONLY` for `ActionGenerator` and `Configuration`.
Is the discrepancy intentional?

@moulins I'm not sure if that's what you're referring to, but playerglobals.swf do not actually set these flags. It looks like they made a mistake, because

for StageCapture the flags are set for StageCapture's prototype (o is not being assigned properly), and
ASSetPropFlags(ActionGenerator,null,7); and ASSetPropFlags(Configuration,null,7); do nothing, because ActionGenerator and Configuration are undefined.

And as mentioned above, these things are tested, so I just made sure the flags are set the same way as observed in tests.

This patch stubs: * flash.automation.Configuration, * flash.automation.ActionGenerator, * flash.automation.StageCapture.

@SuchAFuriousDeath

-------------------------------------------------------------------------------------------------------- batocera-emulationstation.mk 1a8599295a8ca0741c07f796d9087f5af9481a4d # Version: Commits on Jan 31, 2026 -------------------------------------------------------------------------------------------------------- Merge pull request #2067 from dmanlfc/merge-info provide more info about the merge drive source, ------------------------------------------------------------------------------------------------ batocera-es-piboy.mk 1a8599295a8ca0741c07f796d9087f5af9481a4d # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------------ Merge pull request #2067 from dmanlfc/merge-info provide more info about the merge drive source, ------------------------------------------------------------------------------------------ dolphin-emu.mk b1020186519d690a9b64a215f00da7453ab2803b # Version: Commits on Jan 30, 2026 ------------------------------------------------------------------------------------------ Merge pull request #14307 from Sam-Belliveau/granular-audio-stretching Add an option to preserve audio pitch when emulation speed changes, ------------------------------------------------------------------------------------------ duckstation.mk 1cfde39d3cc52c39cf09035cda4299fc4213918a # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------ Deps: Version updates - Qt 6.10.2 - Harfbuzz 12.3.2 - libpng 1.6.54, ----------------------------------------------------------------------------------- eden.mk 84fdbbaaa13c0498dafc7302166a92c37816d09c # Version: Commits on Jan 31, 2026 ----------------------------------------------------------------------------------- [frontend] Fix build issues with update checker (#3433) ------------------------------------------------------------------------------------- hatari.mk c176e1a1ff1d8dc7a398d781ff5963924292305d # Version: Commits on Jan 22, 2026 ------------------------------------------------------------------------------------- Do not modify INQUIRY additional length based on the request byte count The SCSI-2 spec says: \The additional length field shall specify the length in bytes of the parameters. If the allocation length of the command descriptor block is too small to transfer all of the parameters, the additional length shall not be adjusted to reflect the truncation.\, -------------------------------------------------------------------------------------- openmsx.mk 3eaa46322d032626f92b80dc20c01a837f8c12c3 # Version: Commits on Jan 31, 2026 -------------------------------------------------------------------------------------- Cleanup Phase 3 complete - all GOODMSX references have been removed Easier to identify hacks and bootlegs., ----------------------------------------------------------------------------------- play.mk ee8fee9d7dcadb295f8c0cad87e0441c67da1eaa # Version: Commits on Jan 31, 2026 ----------------------------------------------------------------------------------- GameConfig: Add idle skip for Sled Storm., ------------------------------------------------------------------------------------- ppsspp.mk 2e3ce49858063608f6c2ce80d68db0928009fea1 # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------- Merge pull request #21178 from NABN00B/bouncing-icon Fix RNG of Bouncing Icon BG animation, ------------------------------------------------------------------------------------ rpcs3.mk 1c08439907753a86ee1628f07d5fcbe86bfdda2f # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------ Force disable RPCN IPv6 support for now, ----------------------------------------------------- ryujinx.mk 1.3.249 # Version: Commits on Jan 31, 2026 ----------------------------------------------------- Canary-1.3.249 ----------------------------------------------------------------------------------- ymir.mk 67cc41af6ff31598668cb78225a6181521b6a4db # Version: Commits on Jan 30, 2026 ----------------------------------------------------------------------------------- docs: Document NBA Live 98's mismatched sprite data sizes, ------------------------------------------------------------------------------------------- moonlight-qt.mk 2dda65078f9be61008363a13920d851d544d33bb # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------- Remove D3D9Ex focus loss hint workaround SDL3 doesn't suffer this bug and keeping the default SDL3 auto behavior (minimize iff in exclusive mode) is a better UX., --------------------------------------------------------------- ruffle.mk nightly-2026-01-31 # Version: Commits on Jan 31, 2026 --------------------------------------------------------------- ## What's Changed * web: fix Edge headless WebGL test failures by @SuchAFuriousDeath in ruffle-rs/ruffle#22883 * avm1: Stub `flash.automation.*` classes by @kjarosh in ruffle-rs/ruffle#22517 * avm1: Implement *toXML methods in ExternalInterface by @kjarosh in ruffle-rs/ruffle#22651 * avm1: Fall back to local resolution from special recursion limit in getters by @kjarosh in ruffle-rs/ruffle#22874 * avm1: Set property value after calling setter, not before by @kjarosh in ruffle-rs/ruffle#22885 * avm1: Stub Object.toLocaleString by @kjarosh in ruffle-rs/ruffle#22886 **Full Changelog**: ruffle-rs/ruffle@nightly-2026-01-29...nightly-2026-01-31, ------------------------------------------------------------------------------------ box64.mk 2f9eb362c0763844a66b19751f292d0cd2ef3107 # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------ [LA64_DYNAREC] Fixed 6B IMUL load immediate ([RV64_DYNAREC] too) (#3443), ------------------------------------------------------------------------------------------ devilutionx.mk afdaa2ac5e8e92830e8dac5be1976ea42ae67434 # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------ mods/hellfire.mpq build = with devilutionx.mpq, ------------------------------------------------------------------------------------------ fallout2-ce.mk a478e24c8aeaa1d7dc1cbb0a2b6617d5b64f0b65 # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------ Merge pull request #279 from fallout2-ce/context-menu-fix Update game_mouse.cc to fix context menu, ---------------------------------------------------------------------------------------- supertux2.mk 15555561c383e3d9cc8a09bb8ee44797ea9d95fb # Version: Commits on Jan 31, 2026 ---------------------------------------------------------------------------------------- granito: ignore itself in airborne check, ----------------------------------------------------- ledspicer.mk 0.7.3 # Version: Commits on Jan 30, 2026 ----------------------------------------------------- This release focuses on improving project isolation, robustness, and reliability, while fixing long-standing multi-device issues. ## Highlights - Introduces support for **separate project directories**, enabling cleaner management of multiple setups. - Fixes an issue where **only one Servostik board** worked in multi-board configurations. - Improves **PulseAudio handling** with non-fatal reconnect logic for more reliable audio-driven animations. - Adds and stabilizes **unit test coverage**, with full CI validation. ## Notable Changes - New `-j / --project` and `-J / --projects-dir` command-line options. - Centralized and consistent path handling across the codebase. - Improved systemd service behavior with graceful shutdown and optional audio integration. - Correct home directory resolution when running with dropped privileges. ## Compatibility - No configuration changes are required for existing single-project setups. - Multi-project users may benefit from migrating to the new project directory structure. ## Quality - All unit tests pass (27/27). - CI builds validate both test-only and full builds. As always, feedback and bug reports are welcome. ---------------------------------------------------- rclone.mk v1.73.0 # Version: Commits on Jan 30, 2026 ---------------------------------------------------- This is the v1.73.0 release of rclone. Full details of the changes can be found in [the changelog](https://rclone.org/changelog/#v1-73-0-2026-01-30). , --------------------------------------------------------------------------------------- vpinball.mk b6ce3b4dca05ffda13da3f22654f95950a411a44 # Version: Commits on Jan 30, 2026 --------------------------------------------------------------------------------------- Win32 UI: disable accelerators in Edit controls Avoid deleting objects when pressing delete in an edit, ..., ---------------------------------------------------------------------------------------- doomretro.mk cd15520e87843dfa6e410137f37e169fa90b1e9b # Version: Commits on Jan 31, 2026 ---------------------------------------------------------------------------------------- Fix crash calculating light level for blood splats, ---------------------------------------------------------------------------------- trx.mk 5a2b1ed62192179ca3081ff078ec3241018f0d06 # Version: Commits on Jan 30, 2026 ---------------------------------------------------------------------------------- savegame: fix reading tr1 carried items Resolves #4758., ------------------------------------------------------------------------------------------------- libretro-geargrafx.mk bbcda1179c4462a7e6997cca93a30cb11f7069ef # Version: Commits on Jan 31, 2026 ------------------------------------------------------------------------------------------------- Add context menu option to save all sprites to folder. Fix #64, -------------------------------------------------------------------------------------------- libretro-pc98.mk 696c03b5d2cc6d67450b62276fb945d791fa6be1 # Version: Commits on Jan 31, 2026 -------------------------------------------------------------------------------------------- clean SDL code, ---------------------------------------------------------------------------------------------- libretro-ppsspp.mk 2e3ce49858063608f6c2ce80d68db0928009fea1 # Version: Commits on Jan 31, 2026 ---------------------------------------------------------------------------------------------- Merge pull request #21178 from NABN00B/bouncing-icon Fix RNG of Bouncing Icon BG animation,

kjarosh added A-avm1 Area: AVM1 (ActionScript 1 & 2) T-compat Type: Compatibility with Flash Player waiting-on-review Waiting on review from a Ruffle team member labels Dec 14, 2025

moulins reviewed Dec 16, 2025

View reviewed changes

Comment thread core/src/avm1/globals/automation_action_generator.rs Outdated

moulins reviewed Dec 16, 2025

View reviewed changes

Comment thread core/src/avm1/globals/automation_configuration.rs Outdated

kjarosh force-pushed the avm1-sutomation-stub branch from d0882ce to 001e2f6 Compare December 16, 2025 16:48

kjarosh added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels Dec 16, 2025

kjarosh force-pushed the avm1-sutomation-stub branch from 001e2f6 to 8e41ae9 Compare December 18, 2025 09:30

kjarosh force-pushed the avm1-sutomation-stub branch from 8e41ae9 to d9bc879 Compare December 21, 2025 21:23

kjarosh added waiting-on-review Waiting on review from a Ruffle team member and removed waiting-on-author Waiting on the PR author to make the requested changes labels Dec 21, 2025

kjarosh requested a review from moulins December 21, 2025 21:24

kjarosh force-pushed the avm1-sutomation-stub branch from d9bc879 to 7def377 Compare December 26, 2025 10:33

kjarosh force-pushed the avm1-sutomation-stub branch from 7def377 to 1ca543c Compare January 2, 2026 20:32

kjarosh force-pushed the avm1-sutomation-stub branch from 1ca543c to 4626771 Compare January 14, 2026 19:08

SuchAFuriousDeath approved these changes Jan 30, 2026

View reviewed changes

avm1: Stub flash.automation.* classes

f78eb19

This patch stubs: * flash.automation.Configuration, * flash.automation.ActionGenerator, * flash.automation.StageCapture.

kjarosh force-pushed the avm1-sutomation-stub branch from 4626771 to f78eb19 Compare January 30, 2026 12:02

kjarosh enabled auto-merge (rebase) January 30, 2026 12:08

kjarosh merged commit 49ef097 into ruffle-rs:master Jan 30, 2026
26 checks passed

kjarosh removed the waiting-on-review Waiting on review from a Ruffle team member label Jan 30, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

avm1: Stub `flash.automation.*` classes#22517

avm1: Stub `flash.automation.*` classes#22517
kjarosh merged 1 commit intoruffle-rs:masterfrom
kjarosh:avm1-sutomation-stub

kjarosh commented Dec 14, 2025

Uh oh!

Uh oh!

Uh oh!

moulins commented Dec 16, 2025

Uh oh!

kjarosh commented Dec 16, 2025

Uh oh!

kjarosh commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kjarosh commented Dec 14, 2025

Uh oh!

Uh oh!

Uh oh!

moulins commented Dec 16, 2025

Uh oh!

kjarosh commented Dec 16, 2025

Uh oh!

kjarosh commented Dec 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants