Skip to content

feat: surface handler results to middleware chain #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bougyman merged 1 commit into from
Apr 29, 2026
Merged

feat: surface handler results to middleware chain #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/leopard/message_processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,13 @@ def base_app(handler, callbacks)
lambda do |wrapper|
result = execute_handler.call(wrapper, handler)
process_result(wrapper, result, callbacks)
# TODO: document that middleware functions are expected to propagate result
# https://github.com/rubyists/leopard/issues/48
result
Copy link
Copy Markdown
Member

@bougyman bougyman Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why wouldn't #process_result just return a Result?

Copy link
Copy Markdown
Contributor Author

@pmcclory-pp pmcclory-pp Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure i'm following. so we need to pass the result of actually executing the handler to the middleware chain. process_result just takes the result that is returned and calls the appropriate callback for the transport (req/reply or jetstream).

rescue StandardError => e
logger.error 'Error processing message: ', e
callbacks[:on_error].call(wrapper, e)
Dry::Monads::Result::Failure.new(e)
end
end

Expand Down
Loading